Repository navigation
Fail CI on svelte-check warnings like the local build - #2
Merged
Merged
Conversation
scripts/build.sh runs svelte-check with --fail-on-warnings, CI didn't, so a pull request could pass CI and then fail the release build. The CI header no longer claims it builds the whole binary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rewrap the checks line in AGENT.md, and add --fail-on-warnings to the webui check script so it rejects the same warnings as CI and build.sh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI and AGENT.md now run svelte-check with --fail-on-warnings like scripts/build.sh (no warnings today), and the CI header comment says what CI really does (checks, tests, webui build, no release binary).