Repository navigation
fix(deps): make Vitest 5 available at the project root - #141
Merged
Merged
Conversation
Declare Vitest directly so the plugin's type checker and test runner can resolve it. Reference that version from the transitive override and add Node 24 types to satisfy Vitest 5's peer dependency. Assisted-by: GPT-6.1 Signed-off-by: gambtho <Thomas.Gamble@microsoft.com>
TamaraNocentini
force-pushed
the
fix/vitest-5-resolution
branch
from
October 24, 2026 15:29
f875779 to
ec5f0b7
Compare
TamaraNocentini
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking up the Vitest 5 bump from #43. It ended up nested under Headlamp, so type-checking couldn't find
vitest/globalsand the test runner couldn't find the CLI.This makes Vitest a direct dev dependency and points the override at it. Node 24 types satisfy its peer requirement; TypeScript stays on 5.9.3.
Checked a clean install, lint, types, all 123 tests, build, and formatting.
/polishand the local CodeRabbit review came back clean.AI-assisted.