Skip to content

Fix Run go-makefile-maker check after dependencyDashboard object migration - #391

Merged
fwiesel merged 1 commit into
mainfrom
fix/renovate-dashboard-config
Nov 13, 2026
Merged

fwiesel merged 1 commit into
mainfrom
fix/renovate-dashboard-config

Conversation

@fwiesel

@fwiesel fwiesel commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Every open PR fails the "Run go-makefile-maker" check with:

2026/11/13 10:03:09 FATAL:  INFO: Validating .github/renovate.json5
ERROR: Found errors in configuration
       "file": ".github/renovate.json5",
       "errors": [
         {
           "topic": "Configuration Error",
           "message": "Configuration option `dependencyDashboard` should be boolean. Found: {\"osvVulnerabilitySummary\":\"all\"} (object)"
         }
       ]
exit status 1

go-makefile-maker@latest (sapcc/go-makefile-maker#673, merged this morning) now generates the dependencyDashboard options as an object, following Renovate's migration of the Dependency Dashboard configuration into that object (renovatebot/renovate#47732); the flat dependencyDashboardOSVVulnerabilitySummary spelling is deprecated. In that object form dependencyDashboard is no longer a boolean, but our workflow installs the config validator without setting up Node.js first, so npm resolves renovate to 42.99.0 — the newest release whose engines still allow the runner's default Node — and that version predates the migration and rejects the object form. Since the maker validates its own regenerated output, the check fails regardless of what the committed file says.

This adopts the regenerated .github/renovate.json5 (dependencyDashboard as an object) and the regenerated workflow (a "Set up Node.js" step before installing the validator, so a current renovate gets installed). Verified locally: renovate 44.238.0 accepts the new config ("Config validated successfully against 1 file(s)"), while 42.99.0 reproduces the exact error above on it.

All open PRs' checks are currently blocked on this.

go-makefile-maker (sapcc/go-makefile-maker#673,
merged 2026-11-13) now emits the dependencyDashboard options as an
object, following Renovate's migration of the Dependency Dashboard
configuration into that object
(renovatebot/renovate#47732), and its workflow
template sets up Node.js before installing the Renovate config
validator.

Without that Node.js step, npm resolves the unpinned `npm install
--global renovate` to 42.99.0 on the runner's default Node (the newest
release whose engines still allow Node 22), and 42.99.0 predates the
object form, so it fails the "Run go-makefile-maker" check on every
open PR:

    Configuration option `dependencyDashboard` should be boolean.
    Found: {"osvVulnerabilitySummary":"all"} (object)

Adopt the regenerated renovate.json5 and workflow so the check
validates again with a current Renovate (verified locally with
renovate 44.238.0).

Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
@fwiesel
fwiesel merged commit cfee313 into main Nov 13, 2026
9 checks passed
@fwiesel
fwiesel deleted the fix/renovate-dashboard-config branch November 13, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants