Repository navigation
Fix Run go-makefile-maker check after dependencyDashboard object migration - #391
Merged
Merged
Conversation
go-makefile-maker (sapcc/go-makefile-maker#673, merged 2026-11-13) now emits the dependencyDashboard options as an object, following Renovate's migration of the Dependency Dashboard configuration into that object (renovatebot/renovate#47732), and its workflow template sets up Node.js before installing the Renovate config validator. Without that Node.js step, npm resolves the unpinned `npm install --global renovate` to 42.99.0 on the runner's default Node (the newest release whose engines still allow Node 22), and 42.99.0 predates the object form, so it fails the "Run go-makefile-maker" check on every open PR: Configuration option `dependencyDashboard` should be boolean. Found: {"osvVulnerabilitySummary":"all"} (object) Adopt the regenerated renovate.json5 and workflow so the check validates again with a current Renovate (verified locally with renovate 44.238.0). Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
mchristianl
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every open PR fails the "Run go-makefile-maker" check with:
go-makefile-maker@latest (sapcc/go-makefile-maker#673, merged this morning) now generates the dependencyDashboard options as an object, following Renovate's migration of the Dependency Dashboard configuration into that object (renovatebot/renovate#47732); the flat
dependencyDashboardOSVVulnerabilitySummaryspelling is deprecated. In that object formdependencyDashboardis no longer a boolean, but our workflow installs the config validator without setting up Node.js first, so npm resolves renovate to 42.99.0 — the newest release whose engines still allow the runner's default Node — and that version predates the migration and rejects the object form. Since the maker validates its own regenerated output, the check fails regardless of what the committed file says.This adopts the regenerated
.github/renovate.json5(dependencyDashboardas an object) and the regenerated workflow (a "Set up Node.js" step before installing the validator, so a current renovate gets installed). Verified locally: renovate 44.238.0 accepts the new config ("Config validated successfully against 1 file(s)"), while 42.99.0 reproduces the exact error above on it.All open PRs' checks are currently blocked on this.