Repository navigation
fix: refactor: one breakpoints owner (layout.ts); a test fails on any @media width outside the set - #656
Merged
Conversation
…ve from it responsive.svelte.ts and lint-tokens.ts no longer repeat the scale. The breakpoint lint now also reads .astro/.ts/.js files and matchMedia strings, which found two off-scale (max-width: 900px) in site/src (motion.ts, index.astro), now 899.98px. Fail before: 2 new lint tests fail on the old lint; pass after. Closes #649
mvilacad
marked this pull request as ready for review
October 26, 2026 00:35
mvilacad
force-pushed
the
fix/649-refactor-one-breakpoints-owner-layout-ts
branch
from
October 26, 2026 00:35
2a7f697 to
50d0c78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #649
Regression test (written first)
main(paste the failing output)Change
Checklist
bun run validatepassesbun changeset) if the published package changes