Repository navigation
fix: test: touch-target tests read --ca-touch-target instead of hard-coding 44 - #657
Merged
Merged
Conversation
…eral 44 Helpers touchTarget() (packages/ui/tests, browser) and touchTarget(page) (site/tests) resolve the token; 13 component tests, responsive/webkit specs and the layout audit use them. Fail before: the new source guard lists 27 literal-44 comparisons; pass after. Closes #650
mvilacad
force-pushed
the
fix/650-test-touch-target-tests-read-ca
branch
from
October 26, 2026 00:47
9bef79d to
6e7d1d1
Compare
mvilacad
marked this pull request as ready for review
October 26, 2026 00:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #650
Regression test (written first)
main(paste the failing output)Change
Checklist
bun run validatepassesbun changeset) if the published package changes