Repository navigation
fix: refactor: export VISUAL_ROUTES from route-impact.ts and import it in pages.visual.spec - #658
Merged
Conversation
…imports it Fail before: with the old spec the new test 'is the list the visual spec captures, not a copy of it' fails; pass after: 34 pass. Closes #651
mvilacad
force-pushed
the
fix/651-refactor-export-visual-routes-from-route
branch
from
October 26, 2026 00:52
8fc1b5b to
c81164e
Compare
mvilacad
marked this pull request as ready for review
October 26, 2026 00:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #651
Regression test (written first)
main(paste the failing output)Change
Checklist
bun run validatepassesbun changeset) if the published package changes