Repository navigation
fix: refactor: tokens/presets.ts derives every preset field from builtins.ts - #661
Merged
Merged
Conversation
BuiltinPresetId, the studio's BUILTIN_PRESETS_IDS and the landing theme lab derive from BUILTIN_PRESETS; HeroStage's curated six is typed satisfies BuiltinPresetId. Fail before: the new preset-ids-source guard lists 4 modules that hand-list the ids; pass after (83 related tests, svelte-check 0 errors). Closes #654
mvilacad
force-pushed
the
fix/654-refactor-tokens-presets-ts-derives-every
branch
from
October 26, 2026 01:13
9bf0c32 to
5855e5f
Compare
mvilacad
marked this pull request as ready for review
October 26, 2026 01:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #654
Regression test (written first)
main(paste the failing output)Change
Checklist
bun run validatepassesbun changeset) if the published package changes