chore: autocorrect Style/HashSyntax offenses in check-in files - #2837
Merged
Conversation
Autocorrect 15 Style/HashSyntax "Omit the hash value" offenses in app/controllers/check_ins_controller.rb and its spec. These pre-existing offenses on master make every pull request's RuboCop CI job fail, since the job runs on the merge commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every pull request's RuboCop CI job fails because the job runs on the PR-into-master merge commit, and master itself carries 15 pre-existing
Style/HashSyntax: Omit the hash valueoffenses: 2 inapp/controllers/check_ins_controller.rband 13 inspec/controllers/check_ins_controller_spec.rb. Master's push runs have not exercised the RuboCop job since June, so these drifted in unnoticed.Change
rubocop -aautocorrect on the two check-in files: 15 offenses corrected, all mechanicalmember: member->member:shorthand rewrites. No behavior change.Verification
bundle exec rubocop(full repo, on this branch): 374 files inspected, 0 offensesbundle exec rspec spec/controllers/check_ins_controller_spec.rb: 12 examples, 0 failures