Skip to content

chore: autocorrect Style/HashSyntax offenses in check-in files #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mroderick merged 1 commit into from
Sep 2, 2026
+9 −9
Merged

chore: autocorrect Style/HashSyntax offenses in check-in files #2837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/controllers/check_ins_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@ def find_invitation

def find_or_create_invitation(role)
if @check_in_target.is_a?(Event)
Invitation.create_or_find_by(event: @check_in_target, member: current_user, role: role)
Invitation.create_or_find_by(event: @check_in_target, member: current_user, role:)
else
WorkshopInvitation.create_or_find_by(workshop: @check_in_target, member: current_user, role: role)
WorkshopInvitation.create_or_find_by(workshop: @check_in_target, member: current_user, role:)
end
end

Expand Down
14 changes: 7 additions & 7 deletions spec/controllers/check_ins_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

it 'creates an invitation with source=check_in' do
post :create, params: { code: event.check_in_code, role: 'Student' }
invitation = Invitation.find_by(event: event, member: member)
invitation = Invitation.find_by(event:, member:)
expect(invitation.source).to eq(InvitationConcerns::SOURCE_CHECK_IN)
expect(invitation.attending).to be true
expect(invitation.verified).to be true
Expand All @@ -56,28 +56,28 @@

it 'ignores unpermitted parameters' do
post :create, params: { code: event.check_in_code, role: 'Student', hacker_field: 'malicious' }
invitation = Invitation.find_by(event: event, member: member)
invitation = Invitation.find_by(event:, member:)
expect(invitation.source).to eq(InvitationConcerns::SOURCE_CHECK_IN)
expect(response).to redirect_to(check_in_e_confirm_path(code: event.check_in_code))
end

it 'redirects to confirm when already checked in' do
invitation = Fabricate(:invitation, event: event, member: member, role: 'Student', attending: true, verified: true)
invitation = Fabricate(:invitation, event:, member:, role: 'Student', attending: true, verified: true)
post :create, params: { code: event.check_in_code, role: 'Student' }
expect(response).to redirect_to(check_in_e_confirm_path(code: event.check_in_code))
expect(Invitation.find(invitation.id).verified).to be true
end

it 'rejects selecting a different role than the existing invitation' do
Fabricate(:invitation, event: event, member: member, role: 'Student')
Fabricate(:invitation, event:, member:, role: 'Student')
post :create, params: { code: event.check_in_code, role: 'Coach' }
expect(response).to redirect_to(check_in_e_path(code: event.check_in_code))
expect(flash[:alert]).to include('Student')
end

it 'rejects check-in when the role is at capacity' do
event.update!(student_spaces: 1)
Fabricate(:invitation, event: event, member: Fabricate(:member), role: 'Student',
Fabricate(:invitation, event:, member: Fabricate(:member), role: 'Student',
attending: true, verified: true)
post :create, params: { code: event.check_in_code, role: 'Student' }
expect(response).to redirect_to(check_in_e_path(code: event.check_in_code))
Expand All @@ -89,7 +89,7 @@
date_and_time: Time.zone.now - 30.minutes,
ends_at: Time.zone.now + 30.minutes)
post :create, params: { code: workshop.check_in_code, role: 'Student' }
invitation = WorkshopInvitation.find_by(workshop: workshop, member: member)
invitation = WorkshopInvitation.find_by(workshop:, member:)
expect(invitation.source).to eq(InvitationConcerns::SOURCE_CHECK_IN)
expect(invitation.attending).to be true
expect(invitation.attended).to be true
Expand All @@ -101,7 +101,7 @@
workshop = Fabricate(:workshop,
date_and_time: Time.zone.now - 30.minutes,
ends_at: Time.zone.now + 30.minutes)
invitation = Fabricate(:workshop_invitation, workshop: workshop, member: member, role: 'Student')
invitation = Fabricate(:workshop_invitation, workshop:, member:, role: 'Student')
WaitingList.add(invitation)
post :create, params: { code: workshop.check_in_code, role: 'Student' }
expect(response).to redirect_to(check_in_w_path(code: workshop.check_in_code))
Expand Down