Repository navigation
ci: fail zizmor job when SARIF contains findings - #54
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zizmor always exits 0 in SARIF mode, so findings only ever showed up in the code scanning tab and never failed the check. Adds a step after the SARIF upload that fails the job when the SARIF has any results, so findings still reach code scanning but also block the PR. The first run on this PR failed as expected on
self-repositoryfindings; the second commit fixes them and the check went green. Same change as contextbridge/planbridge#288.Review focus
Ordering: the fail step runs after the upload on purpose so results still land in code scanning on failure.
Commits
ceed936— fail zizmor job when SARIF contains findingsbff8c34— use $/ self-repository syntax for local action references