Skip to content

ci: fail zizmor job when SARIF contains findings #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blimmer merged 2 commits into from
Sep 8, 2026
Merged

ci: fail zizmor job when SARIF contains findings #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ceed936
ci: fail zizmor job when SARIF contains findings
blimmer Sep 4, 2026
bff8c34
ci: use $/ self-repository syntax for local action references
blimmer Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/chromatic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
persist-credentials: false

- name: Bootstrap
uses: ./.github/actions/bootstrap
uses: $/.github/actions/bootstrap

- name: Build Storybook
run: bun run build-storybook
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ concurrency:
jobs:
test:
name: Tests
uses: ./.github/workflows/test.yml
uses: $/.github/workflows/test.yml
permissions:
contents: read
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ concurrency:
jobs:
test:
name: Tests
uses: ./.github/workflows/test.yml
uses: $/.github/workflows/test.yml
permissions:
contents: read
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ permissions: {}
jobs:
test:
name: Tests
uses: ./.github/workflows/test.yml
uses: $/.github/workflows/test.yml
permissions:
contents: read

Expand All @@ -28,10 +28,10 @@ jobs:
fetch-depth: 0
persist-credentials: false

- uses: ./.github/actions/bootstrap
- uses: $/.github/actions/bootstrap

- name: Fetch release secrets
uses: ./.github/actions/fetch-release-secrets
uses: $/.github/actions/fetch-release-secrets
with:
role-to-assume: ${{ secrets.RELEASE_ROLE_ARN }}

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
- uses: ./.github/actions/bootstrap
- uses: $/.github/actions/bootstrap
- name: Check formatting
run: bun run format:check
- name: Restore ESLint cache
Expand Down Expand Up @@ -42,7 +42,7 @@ jobs:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
- uses: ./.github/actions/bootstrap
- uses: $/.github/actions/bootstrap
- name: Get Playwright version
id: playwright-version
run: echo "version=$(jq -r '.devDependencies.playwright' package.json)" >> "$GITHUB_OUTPUT"
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/zizmor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,11 @@ jobs:
with:
sarif_file: zizmor.sarif
category: zizmor

# zizmor always exits 0 in SARIF mode, so fail here (after the upload
# so findings still reach code scanning) when the SARIF has results.
- name: Fail on findings
if: steps.changes.outputs.github == 'true'
run: |
jq -r '.runs[].results[] | "\(.level): \(.ruleId) — \(.locations[0].physicalLocation.artifactLocation.uri):\(.locations[0].physicalLocation.region.startLine // "?") \(.message.text)"' zizmor.sarif
jq -e '[.runs[].results[]] | length == 0' zizmor.sarif > /dev/null
Loading