[kwvg]

Additional Information

• As mentioned in rust-dashcore#1223, currently dash-params pulls in codec despite it not being integral to the crate's functionality, which saddles downstream consumers with otherwise-unwanted packages into the dependency graph. Continuing base-sdk#83, we can now make codec optional as it is now underneath dash-primitives (where otherwise codec is essential to the crate and cannot be turned off).

• base-sdk#90 consolidated our Bazel workflows to be per-platform workspace-wide rather than per-platform per-workspace to deal with runner contention, in the process we switched to our own self-hosted caches to work around cache thrashing due to the 10GB limit on caches by GitHub (source).

  Part of this effort was relying on the Bazel Remote Asset API. Due to a quirk in how authentication headers are sent, the reverse proxy was unhappy with the duplication and dropped the query entirely, resulting in longer-than-expected runner occupation. This has been stepped around by using --remote_cache_header.

• As we plan on offering FFIs, the Bazel build configurations need to be split into standard and portable builds, differentiated by portable feature enablement and setting build flags to match. A minor patch to our pinned rules_rust was required to ensure it was correctly propagated.

• With the publication of v0.2.0-beta crates in base-sdk#75, a new project board was created for tracking v0.3.x series crates (source). This required a minor update in our workflow automations.

Breaking Changes

None expected.

How Has This Been Tested?

just lint test

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional tests
• I have made corresponding changes to the documentation
• I did not use agentic assistance (i.e. LLMs, AI) except as disclosed and can answer questions, comments and concerns without said assistance. I assume authorship of the code submitted.
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

Agent disclosure

Code generated with Claude Code using Opus 5.5, medium effort. Reviewed with Codex using GPT-6.1-Sol, medium effort as adversarial review and Claude Code using Fable 5.1, medium effort.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: dashpay/base-sdk
• Branch: develop
• File: .coderabbit.yml
• Commit: cbb97b5
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 4d6faa75-153b-4ec9-8aa9-e8138bd6407b

Commits

Reviewing files that changed from the base of the PR and between cbb97b5 and 342dbbb.

Files ignored due to path filters: 2

• .github/board.json is excluded by !**/*.json
• MODULE.bazel.lock is excluded by !**/*.lock, !**/*.lock

Files selected for processing: 36

• .bazelrc
• .github/actions/bazel_remote/action.yml
• .github/workflows/build_bazel.yml
• MODULE.bazel
• bazel/BUILD.bazel
• bazel/patches/rules_rust-build-script-target-flags.patch
• bazel/rust.MODULE.bazel
• bazel/rust.bzl
• bazel/rustc.bzl
• bazel/toolchains.MODULE.bazel
• bazel/toolchains.bzl
• bazel/workspace.bzl
• maint/lint/lint_bazel.py
• meta/bazel/Cargo.toml
• meta/dev/Cargo.toml
• pkgs/num/BUILD.bazel
• pkgs/p2p_core/BUILD.bazel
• pkgs/p2p_core/Cargo.toml
• pkgs/params/BUILD.bazel
• pkgs/params/Cargo.toml
• pkgs/params/src/addr.rs
• pkgs/params/src/chain.rs
• pkgs/params/src/consensus.rs
• pkgs/params/src/deployment.rs
• pkgs/params/src/genesis.rs
• pkgs/params/src/lib.rs
• pkgs/params/src/llmq.rs
• pkgs/pkc/BUILD.bazel
• pkgs/pow/BUILD.bazel
• pkgs/primitives/BUILD.bazel
• pkgs/primitives/Cargo.toml
• pkgs/script/BUILD.bazel
• pkgs/script/Cargo.toml
• pkgs/script/src/lib.rs
• pkgs/types/BUILD.bazel
• pkgs/types/Cargo.toml

Files with no reviewable changes: 2

• pkgs/types/BUILD.bazel
• pkgs/num/BUILD.bazel

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

• New Features

  • Added portable debug and release build profiles for supported platforms.
  • Portable builds are available for selected libraries and use baseline target settings.

• Improvements

  • Build checks now include portable debug and optimized configurations.
  • Codec support can be selected through package features, allowing builds to omit it where it is not enabled.

The change adds portable Bazel Rust profiles and a module extension that configures and registers Rust toolchains. It also updates build-script target-flag handling and adds portable builds to the Bazel workflow. Across workspace crates, Cargo and Bazel feature selections change, and codec-related source declarations become conditional on the codec feature.

Suggested reviewers: thepastaclaw

Priority: Low

Merge Risk: Minimal · up to 342db

Portable builds and optional codec features introduce no identified merge-blocking risk.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title names the main changes: support for disabling codec in dash-params and dash-script, Bazel configs for portable builds, disabling default-features across the workspace, and a cache …
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description check		The pull request description directly explains the codec feature changes, portable Bazel configurations, cache authentication fix, workflow updates, and testing performed. It matches the changeset.

Full details: Title check

Explanation

The title names the main changes: support for disabling codec in dash-params and dash-script, Bazel configs for portable builds, disabling default-features across the workspace, and a cache credential fix. It is long and lists several changes, but each item appears in the changeset, so it is related to the main change.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Warning

This pull request may have conflicts, please coordinate with the authors of these pull requests.

Potential conflicts

• p2p_core%fix!: align handshake and header sync messages with the reference implementation #86

[thepastaclaw]

✅ Final review complete — no blockers (commit 342dbbb) · triage: normal

[thepastaclaw]

Final validation — Phase 1 + Phase 2

The reviewed range contains no verified correctness, security, or architecture defects. Feature gating preserves the default Cargo behavior and keeps codec-dependent APIs and dependencies aligned; the Bazel portable profiles, toolchain refactor, build-script flag forwarding, lockfile, and cache-header changes are internally consistent. CI has no failures at the captured head, though several build and lint checks remain queued or in progress.

Review provenance

Source: reviewer 1: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 2: muse-spark-1.3-contributor (agent: phase1-reviewer, role: rust-quality); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 4: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

• Triage: normal by gpt-6.1-sol (effort low) — This is a broad, cross-cutting build and Rust feature-configuration change spanning Bazel modules, toolchains, Cargo manifests, and conditional compilation, but it does not modify a critical consensus, funds, cryptographic, networking, or storage surface.
• Phase 1 reviewers: muse-spark-1.3-contributor — general (completed, effort xhigh); agent phase1-reviewer, muse-spark-1.3-contributor — rust-quality (completed, effort xhigh); agent phase1-reviewer
• Phase 1 model: muse-spark-1.3-contributor — not quota-gated; passed over gemini-3.8-flash-high (antigravity quota lookup failed), glm-5.3-flash (not used above high effort; tier asks max)
• Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
• Phase 2 reviewers: gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort high); agent phase2-reviewer