Repository navigation
build(deps): bump astro from v7.3.5 to v7.4.1, remove unused packages - #757
Conversation
Deploying ddev-com-front-end with
|
| Latest commit: |
50bf067
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2a9be1f5.ddev-com-front-end.pages.dev |
| Branch Preview URL: | https://dependabot-npm-and-yarn-majo-3f12.ddev-com-front-end.pages.dev |
63aef5e to
b369f88
Compare
## Short Summary (TL;DR) Brings every dependency up to date, removes the PostCSS setup and other leftovers nothing needs, and keeps the DDEV dev server running in the foreground under Astro 7.4. No site code changed. ## The Issue Dependabot bumped `postcss-nested` to v9, but nothing loads it. `postcss-import` and `postcss-nested` stayed in `package.json` after the Tailwind v4 migration (#312) cut `postcss.config.cjs` down to autoprefixer, `sass` came in with `astro-tabs`, which was later replaced by our own `Tabs.astro`, and `octokit` already depends on `@octokit/auth-app`. Autoprefixer only adds prefixes for browsers older than Tailwind v4's minimum of Safari 16.4, Chrome 111 and Firefox 128, where the site does not work anyway. `src/env.d.ts` repeats what Astro's base `tsconfig` already includes. `npm audit` reports 7 moderate findings, before and after this change: ```text postcss-selector-parser <7.1.6, via @tailwindcss/typography, fix only by downgrading typography to 0.5.4 sprintf-js *, via gray-matter in astro-rehype-relative-markdown-links, no fix available ``` ## How This PR Solves The Issue Ran `npx @astrojs/upgrade` and `npm update`, which moved `astro` to 7.4.0, `@astrojs/mdx` to 8.1.0, `@astrojs/react` to 7.1.0 and the rest within their ranges, so `npm outdated` is empty. Then uninstalled `postcss-nested`, `postcss-import`, `autoprefixer`, `sass` and `@octokit/auth-app`, and deleted `postcss.config.cjs` and `src/env.d.ts`. The "DDEV Website for Contributors" post linked to `postcss.config.cjs`, so that line now links to the Tailwind config and the Typography plugin only. Astro 7.4 no longer depends on esbuild, and removing `sass` drops `@parcel/watcher`, so no installed package has install scripts left on Linux and `npm install-scripts prune` removed the `allowScripts` key. Astro 7.4 starts `astro dev` in the background when it detects an AI agent, and DDEV passes `CLAUDECODE` and `AI_AGENT` into the web container when an agent runs `ddev start`. Supervisor then saw the daemon exit and respawned it every few seconds. The daemon now passes `--ignore-lock`, which keeps the server in the foreground and also skips the `.astro/dev.json` lock that could collide with a new PID after a restart. The `bump-deps` skill is updated to match. ## Manual Testing Instructions ```bash ddev start # check for problems in: ddev logs ddev npm run build ddev npm audit ``` `astro-dev-daemon` should reach RUNNING once and stay there, including when `ddev start` runs from an AI agent. Compare https://dependabot-npm-and-yarn-majo-3f12.ddev-com-front-end.pages.dev against https://ddev.com/, in desktop and mobile views: `/blog/markdown-features-demo/`, `/get-started/` with its tabs, `/usage-stats/`, site search, and the theme toggle. ## Release/Deployment Notes The Cloudflare build no longer installs `sass`, `autoprefixer`, `postcss-import`, `postcss-nested` or `esbuild`. The Tailwind bundle loses `-moz-`, `-o-` and `-webkit-appearance` prefixes that only browsers older than Tailwind v4's minimum need, and keeps the `-webkit-backdrop-filter` and PhotoSwipe prefixes autoprefixer used to strip. 🤖 Developed with assistance from [Claude Code](https://claude.ai/code) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
b369f88 to
007c183
Compare
|
ddev/ddev#8976 fixes the cause, so this PR does not need The leak came from ddev/ddev#8380, which no DDEV release includes yet (it is newer than v1.25.4), so once ddev/ddev#8976 is merged no released version has the problem and 2089a54 drops Tested with a DDEV build of ddev/ddev#8976 by running 🤖 Developed with assistance from Claude Code |
ddev/ddev#8976 stops `ddev start` from passing `AI_AGENT`, `CLAUDECODE` and the other agent variables to supervisord, so `astro dev` stays in the foreground whoever ran `ddev start`, and the flag is no longer needed. The leak came from ddev/ddev#8380, which no DDEV release includes, so `ddev_version_constraint` stays as it is. The `bump-deps` skill keeps the daemon check without naming the flag. 🤖 Developed with assistance from [Claude Code](https://claude.ai/code) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Short Summary (TL;DR)
Brings every dependency up to date, and removes the PostCSS setup and other leftovers nothing needs. No site code changed.
The Issue
Dependabot bumped
postcss-nestedto v9, but nothing loads it.postcss-importandpostcss-nestedstayed inpackage.jsonafter the Tailwind v4 migration (#312) cutpostcss.config.cjsdown to autoprefixer,sasscame in withastro-tabs, which was later replaced by our ownTabs.astro, andoctokitalready depends on@octokit/auth-app.Autoprefixer only adds prefixes for browsers older than Tailwind v4's minimum of Safari 16.4, Chrome 111 and Firefox 128, where the site does not work anyway.
src/env.d.tsrepeats what Astro's basetsconfigalready includes.npm auditreports 7 moderate findings, before and after this change:How This PR Solves The Issue
Ran
npx @astrojs/upgradeandnpm update, which movedastroto 7.4.1,@astrojs/mdxto 8.1.0,@astrojs/reactto 7.1.0 and the rest within their ranges, sonpm outdatedis empty. Then uninstalledpostcss-nested,postcss-import,autoprefixer,sassand@octokit/auth-app, and deletedpostcss.config.cjsandsrc/env.d.ts. The "DDEV Website for Contributors" post linked topostcss.config.cjs, so that line now links to the Tailwind config and the Typography plugin only.Astro 7.4 no longer depends on esbuild, and removing
sassdrops@parcel/watcher, so no installed package has install scripts left on Linux andnpm install-scripts pruneremoved theallowScriptskey.Astro 7.4 runs
astro devin the background when it detects an AI agent. DDEV HEAD after ddev/ddev#8380 passed the agent variables to supervisord, so the daemon kept exiting and respawning, and ddev/ddev#8976 fixes that in DDEV, so the daemon command needs no change. Thebump-depsskill no longer names packages that are gone from itsallowScriptsexample, and its daemon check no longer describes the old.astro/dev.jsoncollision.Manual Testing Instructions
ddev start # check for problems in: ddev logs ddev npm run build ddev npm auditastro-dev-daemonshould reach RUNNING once and stay there.Compare https://dependabot-npm-and-yarn-majo-3f12.ddev-com-front-end.pages.dev against https://ddev.com/, in desktop and mobile views:
/blog/markdown-features-demo/,/get-started/with its tabs,/usage-stats/, site search, and the theme toggle.Release/Deployment Notes
The Cloudflare build no longer installs
sass,autoprefixer,postcss-import,postcss-nestedoresbuild. The Tailwind bundle loses-moz-,-o-and-webkit-appearanceprefixes that only browsers older than Tailwind v4's minimum need, and keeps the-webkit-backdrop-filterand PhotoSwipe prefixes autoprefixer used to strip.🤖 Developed with assistance from Claude Code