Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .claude/skills/bump-deps/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,13 @@ jq -r '.packages | to_entries[] | select(.key | test("(lightningcss|tailwindcss/
npm runs a dependency's install scripts only when `package.json`
`allowScripts` has an entry for it, pinned to `pkg@version` by default.
Otherwise it skips them without failing and lists the skipped packages at the
end of the install output, so a bump of `esbuild` or `@parcel/watcher` that is
not re-approved breaks quietly:
end of the install output, so a package with install scripts that is bumped
or added without approval breaks quietly. `prune` deletes the key once no
installed package has install scripts.

```bash
ddev npm install-scripts ls # unreviewed install scripts
ddev npm install-scripts approve esbuild # rewrites the pin to the installed version
ddev npm install-scripts approve <pkg> # rewrites the pin to the installed version
ddev npm install-scripts prune --dry-run # entries that match nothing installed
ddev npm install-scripts prune
```
Expand Down Expand Up @@ -92,10 +93,9 @@ ddev prettier
```

- The build must finish with astro-link-validator reporting no broken links.
- If `astro-dev-daemon` exits once with "Another astro dev server is already
running" right after a restart, the old `.astro/dev.json` PID collided with a
new process; supervisor restarts it. It is a problem only if it keeps
exiting.
- `astro-dev-daemon` must start once and stay running. If supervisor respawns
it every few seconds, `astro dev` exited on its own, and `ddev logs` shows
why.
- If an audit finding has no fix, say so in the PR with the advisory or
upstream issue, as #637 and #734 did. Replace an unmaintained package
instead of carrying the finding, if one of the existing dependencies can do
Expand Down
6 changes: 2 additions & 4 deletions .ddev/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,8 @@ web_extra_exposed_ports:
https_port: 4321
web_extra_daemons:
- name: astro-dev-daemon
# The extra -- in `npm run dev -- --host` is a Vite requirement
# See https://github.com/vitejs/vite/discussions/3396
# 4321 is the default port for Astro, set it explicitly anyway
# See https://docs.astro.build/en/reference/configuration-reference/#serverport
# npm passes the flags after `--` to `astro dev`. 4321 is Astro's default
# port, set explicitly to match web_extra_exposed_ports.
command: bash -c 'npm install && touch /var/tmp/npm-install-done && npm run dev -- --host --port 4321'
directory: /var/www/html
disable_upload_dirs_warning: true
Expand Down
Loading