Skip to content

Fix display freezing below -9.9 °C and at 100 % humidity, add leading zero at x.9 #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
altoing wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix display freezing below -9.9 °C and at 100 % humidity, add leading zero at x.9 #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,13 +234,18 @@ void read_sensor_and_save() {
}
}
#endif
// the big number only fits -9.9..199.9 with a point; show whole degrees below that
if (displayTemperature < -99) {
hasPoint = 0;
displayTemperature = displayTemperature / 10;
}

// update lcd
show_temp_symbol(tempSymbol);
show_big_number(displayTemperature, hasPoint);
#ifdef ZCL_RELATIVE_HUMIDITY_MEASUREMENT
#ifdef ZCL_TEMPERATURE_MEASUREMENT
show_small_number(g_zcl_relHumidityAttrs.measuredValue / 100, 1);
show_small_number(g_zcl_relHumidityAttrs.measuredValue >= 9900 ? 99 : g_zcl_relHumidityAttrs.measuredValue / 100, 1);
show_battery_symbol(g_zcl_powerAttrs.batteryPercentage <= 20); // in 0.5%
if (!g_zcl_thermostatUICfgAttrs.smileyOn) {
show_smiley(0);
Expand Down
2 changes: 1 addition & 1 deletion src/lcd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ void show_big_number(int16_t number, bool point){
display_buff[4] = point?0x08:0x00;
if(number > 99)display_buff[5] |= display_numbers[number / 100 % 10] & 0xF7;
if(number > 9)display_buff[4] |= display_numbers[number / 10 % 10] & 0xF7;
if(number < 9)display_buff[4] |= display_numbers[0] & 0xF7;
if(number < 10)display_buff[4] |= display_numbers[0] & 0xF7;
display_buff[3] = display_numbers[number %10] & 0xF7;
}

Expand Down