Skip to content

Import the host's ProseMirror in @dev.fast/canvas instead of bundling one - #1550

Merged
thesiti92 merged 1 commit into
mainfrom
canvas-shared-tiptap-pm
Nov 16, 2026
Merged

thesiti92 merged 1 commit into
mainfrom
canvas-shared-tiptap-pm

Conversation

@thesiti92

Copy link
Copy Markdown
Contributor

What / why

@dev.fast/canvas inlined its own ProseMirror (@tiptap/pm 3.31.4) into the lazy BoardEditor chunk. Cloudboard now has a Tiptap composer on 3.33.0, so a page that loads both would carry two copies.

Change

  • @tiptap/pm/* is external in the package build, next to React, and a peer dependency (^3.33.0) of @dev.fast/canvas.
  • @tiptap/pm goes from 3.31.4 to 3.33.0 for Desktop too.
  • check-pack fails if the tarball stops importing @tiptap/pm/view.
  • @dev.fast/canvas becomes 0.6.0: hosts must now install @tiptap/pm.

Result

BoardEditor chunk: 314 KB to 78 KB raw. In a cloudboard build against this tarball, the canvas editor and the composer import one shared 215 KB ProseMirror chunk, loaded only by those two lazy chunks.

Checked

  • packages/canvas: pnpm test (build, pack check, SSR tests).
  • @dev.fast/review-canvas: typecheck and the board-editor tests (187 passed) on 3.33.0.
  • Cloudboard built, typechecked and unit-tested against the packed 0.6.0 tarball.

After merge

Publish @dev.fast/canvas@0.6.0, then bump it in cloudboard.

@dev-fast-stg dev-fast-stg Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by thesiti92.

@thesiti92
thesiti92 merged commit 4793780 into main Nov 16, 2026
1 of 3 checks passed
@thesiti92
thesiti92 deleted the canvas-shared-tiptap-pm branch November 16, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants