Repository navigation
Import the host's ProseMirror in @dev.fast/canvas instead of bundling one - #1550
Merged
Merged
Conversation
sidkmenon
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / why
@dev.fast/canvasinlined its own ProseMirror (@tiptap/pm3.31.4) into the lazyBoardEditorchunk. Cloudboard now has a Tiptap composer on 3.33.0, so a page that loads both would carry two copies.Change
@tiptap/pm/*is external in the package build, next to React, and a peer dependency (^3.33.0) of@dev.fast/canvas.@tiptap/pmgoes from 3.31.4 to 3.33.0 for Desktop too.check-packfails if the tarball stops importing@tiptap/pm/view.@dev.fast/canvasbecomes 0.6.0: hosts must now install@tiptap/pm.Result
BoardEditorchunk: 314 KB to 78 KB raw. In a cloudboard build against this tarball, the canvas editor and the composer import one shared 215 KB ProseMirror chunk, loaded only by those two lazy chunks.Checked
packages/canvas:pnpm test(build, pack check, SSR tests).@dev.fast/review-canvas: typecheck and theboard-editortests (187 passed) on 3.33.0.After merge
Publish
@dev.fast/canvas@0.6.0, then bump it in cloudboard.