Repository navigation
msix: sign and install tests run sign.ps1, not the launcher - #9761
Merged
Merged
Conversation
…9753) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #9753
Root cause: #9672 moved msix_sign to rules_dx powershell_binary.
$(rlocationpath :app_sign)now resolves to the launcher (app_sign.baton Windows), and both tests ran it withpwsh -File, which fails before signtool runs (not a .ps1). Tests now point DX_MSIX_SIGN at//:sign.ps1and throw if it is not a .ps1.Checked:
bazel build //tests:allin families/msix on Linux. Nested-Bazel and consumer tests were not run.Evidence runs (windows_x86_64, not yet awaited): sign_test 42606413135, install_test 42606417119.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B