Repository navigation
wrappers: make php, ruby, zig, dart, elixir and perl bench wrappers keyword-only - #9768
Merged
Merged
Conversation
…eyword-only Their signatures took positional arguments after name, which fails libs/starlark/wrapper_signatures.sh. Every caller already passes these arguments by keyword. Closes #9766 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9766
php_bench,ruby_bench,zig_bench,dart_bench,elixir_benchandperl_benchtook positional arguments aftername, solibs/starlark/wrapper_signatures.shfailed for them. Each now takesname, *, ..., matching the other wrappers. All callers in the repo already pass these arguments by keyword, so no call site changes.Verified locally:
bazel teston//php/rules:wrapper_signature_test,//ruby/rules:wrapper_signature_test,//zig/rules:wrapper_signature_test,//dart/rules:wrapper_signature_test,//elixir/rules:wrapper_signature_testand//perl/rules:wrapper_signature_test: all 6 PASSED.Not run: nested-Bazel and
*_consumer_testtargets (CI runs them). The bench targets underfamilies/anddart/tests/benchwere not built.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B