Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dart/rules/defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def dart_test(name, *, main = None, srcs = None, visibility = None, **kwargs):
kwargs = dx_language_kwargs(kwargs, DART_DEFERRED_SKIP_TAGS, DART_COMPATIBLE_WITH)
dx_wrap_test(name, _dart_test, _dart_forward_test, srcs, visibility = visibility, upstream_kwargs = dict(kwargs, main = main), quality_srcs = dx_entry_quality_srcs(main, srcs), **kwargs)

def dart_bench(name, main = None, srcs = None, deps = None, tags = None, **kwargs):
def dart_bench(name, *, main = None, srcs = None, deps = None, tags = None, **kwargs):
"""A dart_test run by dx bench: `main` calls runBenchmarks from package:dx_bench with BenchmarkBase objects, which writes dx-bench.json."""
dart_test(
name = name,
Expand Down
2 changes: 1 addition & 1 deletion elixir/rules/defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ def elixir_test(name, *, srcs = None, visibility = None, **kwargs):
apps = {"apps": kwargs["deps"]} if kwargs.get("deps") else None
dx_wrap_test(name, _ex_unit_test, _ex_unit_forward_test, helper_first(srcs), visibility = visibility, upstream_kwargs = upstream, extra_forward_kwargs = apps, **kwargs)

def elixir_bench(name, srcs, tags = None, deps = None, **kwargs):
def elixir_bench(name, *, srcs, tags = None, deps = None, **kwargs):
"""elixir_test run by dx bench: DxBench.run in srcs runs Benchee and writes dx-bench.json."""
elixir_test(
name = name,
Expand Down
2 changes: 1 addition & 1 deletion perl/rules/defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def perl_test(name, *, srcs = None, main = None, visibility = None, **kwargs):
upstream = dict(kwargs, main = main)
dx_wrap_test(name, _perl_test, _perl_forward_test, srcs, visibility = visibility, upstream_kwargs = upstream, extra_forward_kwargs = {"deps": kwargs.get("deps", [])}, quality_srcs = dx_entry_quality_srcs(main, srcs), **kwargs)

def perl_bench(name, srcs = None, main = None, deps = None, tags = None, **kwargs):
def perl_bench(name, *, srcs = None, main = None, deps = None, tags = None, **kwargs):
"""A perl_test run by dx bench: scripts call DxBench::run_benchmarks, which times them with core Benchmark and writes dx-bench.json."""
perl_test(
name = name,
Expand Down
2 changes: 1 addition & 1 deletion php/rules/defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def php_test(name, *, srcs = None, visibility = None, **kwargs):
kwargs = dx_language_kwargs(kwargs, PHP_DEFERRED_SKIP_TAGS, PHP_COMPATIBLE_WITH)
dx_wrap_test(name, _php_test, _php_forward_test, srcs, visibility = visibility, quality_srcs = dx_entry_quality_srcs(None, srcs), **kwargs)

def php_bench(name, benches, data = None, env = None, tags = None, **kwargs):
def php_bench(name, *, benches, data = None, env = None, tags = None, **kwargs):
"""A php_test run by dx bench: phpbench runs the `benches` files, one class per file named like the file, and the result is written as dx-bench.json."""
phar = Label("@dx_phpbench//:phpbench.phar")
php_test(
Expand Down
2 changes: 1 addition & 1 deletion ruby/rules/defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def ruby_test(name, *, srcs = None, main = None, visibility = None, **kwargs):
upstream = dict(kwargs, main = main) if main != None else kwargs
dx_wrap_test(name, _rb_test, _ruby_forward_test, srcs, visibility = visibility, upstream_kwargs = upstream, quality_srcs = dx_entry_quality_srcs(main, srcs), **kwargs)

def ruby_bench(name, main, srcs = None, data = None, env = None, tags = None, **kwargs):
def ruby_bench(name, *, main, srcs = None, data = None, env = None, tags = None, **kwargs):
"""A ruby_test run by dx bench: `main` calls DxBench.run with a benchmark-ips block, which writes dx-bench.json."""
ips = Label("@dx_ruby_bench_gems//:benchmark-ips-2.14.0/lib/benchmark/ips.rb")
ruby_test(
Expand Down
2 changes: 1 addition & 1 deletion zig/rules/defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def zig_test(name, *, main = None, srcs = None, visibility = None, **kwargs):
}))
dx_wrap_test(name, _zig_test, _zig_forward_test, srcs, visibility = visibility, upstream_kwargs = upstream, quality_srcs = dx_entry_quality_srcs(main, srcs), main = main, extra_forward_kwargs = {"deps": kwargs.get("deps", [])}, coverage_collector = ZIG_COVERAGE_COLLECTOR, **kwargs)

def zig_bench(name, main = None, srcs = None, visibility = None, tags = None, **kwargs):
def zig_bench(name, *, main = None, srcs = None, visibility = None, tags = None, **kwargs):
"""A ReleaseFast zig_binary plus a `<name>` runner that writes dx-bench.json for `dx bench`."""
binary = name + "_bin"
build, run = split_test_kwargs(kwargs)
Expand Down
Loading