Repository navigation
Join: "Joining XX%" under the bar, and its settings lock while it runs (2.0.0-beta.8) - #11
Merged
Merged
Conversation
…t runs The clip list goes inert and grey, and Join into, File name and Browse are disabled, until the join ends however it ends. A file dropped on Join mid-run isn't added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things found on beta.7's Join page, and the bump to 2.0.0-beta.8.
Tests: 207 passing. Driven in the running app with two clips that re-encode: the text read "Joining 48%", the list and fields were locked, a click on Remove did nothing, and everything came back after the join.