Repository navigation
Restart Now's busy question is cleared however a conversion or a join ends - #9
Merged
Merged
Conversation
… ends converting and joinRunning were cleared only when the run resolved; a run that threw left Restart Now asking about a conversion that wasn't running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convertingandjoinRunning(whatmountShell'sbusyreads for Restart Now) were cleared only when the run resolved. A run whose IPC call threw left them set, so Restart Now kept asking "A conversion is running." until the app restarted.finally.test/kit.test.jsholds thebusywording and bothfinallyblocks.Found in a code review of beta.6's manual-testing section.
npm test199/199.