Repository navigation
Fix --config mlflow:<run> against pre-MLflow-3 tracking servers (404) - #7
Merged
Merged
Conversation
MlflowClient.list_artifacts(run_id, ...) in the MLflow 3 client also calls /api/2.0/mlflow/logged-models/search, which mlflow.dmidev.org doesn't have, so --config mlflow:<run> failed with a 404 before looking at a single file. List and download through the run's artifact repository (built from run.info.artifact_uri), which only uses the artifact endpoints. Checked against mlflow.dmidev.org. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mlcast train --config mlflow:<run>(from #6) failed on 27sj894 with:Cause: in the MLflow 3 client (3.11 here),
MlflowClient.list_artifacts(run_id, path)goes through theruns:/artifact repository, which also searches for MLflow 3 "logged models". mlflow.dmidev.org is older and has no such endpoint, so the very first listing (config/) failed. My end-to-end test for #6 used a local file store, which never takes that path.Fix: list and download through the run's artifact repository, built from
run.info.artifact_uri(mlflow-artifacts:/114/<run>/artifacts), which only uses the artifact endpoints the server has.Testing
intrigued-sow-455: lists the artifacts, downloadsconfig/tmpm6d5s5g9.yaml, finds no uploaded checkpoints and falls back to the local114/<run>/checkpointsas intended.MlflowClient.list_artifactsis never called and the repository is built from the run'sartifact_uriand the URL's server. Full suite: 170 passed, 5 skipped.🤖 Generated with Claude Code