Skip to content

自查頁遷移只保留同義改名,移除三題實質改題映射(PR #19 Copilot 留言跟進) - #23

Merged
doggy8088 merged 2 commits into
zh-twfrom
fix/copilot-pr19-migration
Nov 10, 2026
Merged

doggy8088 merged 2 commits into
zh-twfrom
fix/copilot-pr19-migration

Conversation

@doggy8088

Copy link
Copy Markdown
Owner

跟進 PR #19 的 Copilot review 留言(https://github.com/doggy8088/HowToLiveBetter/pull/19#discussion_r4522901039,高嚴重度),查證屬實:

PR #19 加入的舊答案遷移,把火災、稅務、健保三題的實質改題當成同義改名,舊答案 y 會讓尚未確認的新動作被計為已完成:

  • 濃煙關門:舊題只問貼地走、摸門、走樓梯,新題多了小火快逃、濃煙關門、出去了別回頭。
  • 綜合所得稅結算申報:舊題是做個稅彙算、填專項附加扣除,新題是五月辦綜所稅結算申報、扣除額先比過再選,制度不同。
  • 眷屬依附加保:舊題是在醫保 App 上辦家庭共濟,新題是家人的健保都用眷屬依附加保、沒有漏保,不能互相證明。

修正(只改管線層 convert.mjs,由管線重產):

  • 移除上述三組映射,只保留題意未變的四組(乙醯胺酚、瓦斯軟管、不把銀行帳戶、聯徵信用報告)。
  • 管線註解寫明原則:只遷移同義改名,題面實質改寫者刻意不遷移,留給讀者重答。

驗證:自上游 dff814d 完整重產,七道閘門全綠;重產樹與本分支差異僅 selfcheck.html(−3 行,映射表剩四組)。

Assisted-by: Muse

PR #19 的遷移把火災、稅務、健保三題的實質改題當成同義改名,
舊答案 y 會讓尚未確認的新動作被計為已完成(例如舊題「在醫保
App 上辦了家庭共濟」不能證明眷屬已依附加保)。移除這三組映射,
只沿用題意未變的答案,留給讀者重答;管線註解寫明此原則,
避免日後有人補回。

Assisted-by: Muse
PR #19 的遷移把火災、稅務、健保三題的實質改題當成同義改名,
舊答案 y 會讓尚未確認的新動作被計為已完成。移除這三組映射,
只沿用題意未變的答案,留給讀者重答。

Assisted-by: Muse
Copilot AI balanced review requested due to automatic review settings November 10, 2026 09:44
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-10T09:44:55.382940Z
We couldn’t complete this review. Comment @codex review to try again.
d97ce34 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@doggy8088
doggy8088 merged commit 81e167a into zh-tw Nov 10, 2026
7 checks passed
@doggy8088
doggy8088 deleted the fix/copilot-pr19-migration branch November 10, 2026 09:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

僅移除映射無法使三題先前遷移並儲存的舊答案失效,結果頁仍會將尚未確認的新動作計為已完成。

1 open issue
What changed in this PR

此 PR 跟進 PR #19,限制自查頁的舊答案遷移範圍,避免將舊題答案套用到動作已改變的新題。

Changes:

  • 移除火災、稅務及健保三題的遷移映射,保留四組同義改名。
  • 同步更新轉換管線與產生的頁面,並在管線註解說明遷移原則。
File Description
selfcheck.html 移除三組實質改題的舊答案映射。
scripts/​zh-tw/​convert.mjs 同步調整遷移程式碼範本,補充僅遷移同義改名的註解。

Review effort: Balanced

Comment thread scripts/zh-tw/convert.mjs Resolved
SanHsien added a commit to SanHsien/HowToLiveBetter that referenced this pull request Nov 10, 2026
…8088#20 birth-doc fixes, selfcheck synonym migration); 苯二氮平

Baselines: direct 81e167a / PR 23 / Issue 20; root Issue 175 declined.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
doggy8088 added a commit that referenced this pull request Nov 10, 2026
實質改題三題加 rev:2,使已遷移的舊答案失效(PR #23 Copilot 留言跟進)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants