Repository navigation
Rust #325: give child runs their parent's memos and search attributes - #874
Merged
Merged
Conversation
Published PHP copies a parent run's memos and search attributes to its child's first run, and a failed child run's to the run retrying it (inheritTypedVisibilityMetadata). Native copied them only on continue-as-new. That copy is now two shared helpers, used for the child's first run and its retries too, so their descriptions, run lists and visibility queries match PHP's. The child-visibility fixture records it against published 2.11.7. A child backoff sent as an object is also checked at admission, as PHP reads its values. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
12 tasks
|
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Part of #325. Follows #869.
What changes
Published PHP copies memos and search attributes to new child runs (
inheritTypedVisibilityMetadata), each copy recorded as inherited at sequence 1:Native copied them only on continue-as-new. So a child's description and run list showed an empty memo, and a visibility query for the parent's attribute did not find the child.
continuations.rs:inheritable_memosandinherit_visibility.start_childand the child retry call them right after creating the run. Continue-as-new uses them unchanged.Fixture
child-visibilityRaw worker HTTP on protocol 1.20, in a fresh namespace with one registered keyword attribute. A parent started with a memo and the attribute starts one child under a retry policy. The probe records:
Local checks
child-visibility. It passes on a fresh published 2.11.7 harness and on native built from this branch, andcompareaccepts the pair.child-retriesandcontinue-transferspass on that native image.a_child_and_its_retry_inherit_the_parents_memos_and_search_attributesand an object-backoff extreme-value control.PhpImageContextTestlocal false failure.Checkpoint.
🤖 Generated with Claude Code