[RoiSoleil]

TychoConnectorTest.importTychoPlugin randomly fails on most pull requests with:

M2EClasspath Container not found! (…JRE_CONTAINER…, org.eclipse.pde.core.requiredPlugins, /pde.tycho.plugin/src/

This is not a test problem but a bug in the PDE connector.

If the plug-in model of a Tycho project is not available yet when the project is configured, PDEProjectHelper computes its PDE classpath later, once PDE has loaded the model (CLASSPATH_UPDATER). That update replaces the whole raw classpath by the one computed by PDE ("clear existing entries"), so it removes the Maven classpath container the Java configurator added in the meantime. Whether the model is available in time depends on PDE's resource change listener, hence the random failures — and the container is really lost for the user in that case.

The Maven classpath container of the project is now kept when its PDE classpath is set.

Testing

PDEProjectHelperTest (new) runs the deferred update on an imported project. Without the fix it fails with exactly the classpath reported by the CI failures; with it, all the tests of org.eclipse.m2e.pde.connector.tests pass locally on Linux.

The two other test fixes initially part of this PR are now in #2266 (ConsoleTest) and #2267 (MavenTargetDependencyEditorTest).

🤖 Generated with Claude Code

https://claude.ai/code/session_01SscofYwGFw413Xrn8R2AUq

[github-actions]

Test Results

  351 files    351 suites   1h 19m 22s ⏱️
  732 tests   716 ✅ 16 💤 0 ❌
2 196 runs  2 148 ✅ 48 💤 0 ❌

Results for commit 282c99c.

♻️ This comment has been updated with latest results.

[laeubi]

@RoiSoleil would you mind to create one PR for each of the proposed test fixes? That would make it easier to review and possibly merge in isolation.

[RoiSoleil]

@laeubi Sure, done:

• this PR now only contains the fix of the PDE connector (the Maven classpath container lost when the PDE classpath is updated later, behind the TychoConnectorTest.importTychoPlugin failures);
• Wait for the console output to be complete in ConsoleTest #2266 is the ConsoleTest fix;
• Attempt to stabilize MavenTargetDependencyEditorTest.testAddMavenLocation #2267 is the attempt for MavenTargetDependencyEditorTest.testAddMavenLocation.

The three are independent of each other.

[laeubi]

Lets see how it behaves with the other failures fixed. The whole PDEHelper Code looks really brittle ... so I need to check the details in more depth.

[RoiSoleil]

Looks like OK