Repository navigation
Attempt to stabilize MavenTargetDependencyEditorTest.testAddMavenLocation - #2267
Merged
Merged
Conversation
…tion The test sometimes fails because the value typed into the first cell of the new row is lost: expected:<[<required>]> but was:<[org.apache.commons]> The dialog updates its table asynchronously when its model changes, so the test may edit a cell while the update triggered by "Add" is still pending. It also looked for the cell editor among all the text widgets of the dialog, and so silently typed into the location label if no cell editor was active. Process the pending UI events before a cell is edited, and look for the cell editor in the table only, so that the test fails with a clear message if the editor could not be activated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SscofYwGFw413Xrn8R2AUq
RoiSoleil
force-pushed
the
fix-target-editor-test
branch
from
October 8, 2026 04:42
4dfc93c to
3182fe6
Compare
Test Results 345 files ±0 345 suites ±0 1h 24m 14s ⏱️ + 2m 22s For more details on these errors, see this check. Results for commit 3182fe6. ± Comparison against base commit 8bc713d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #2265, as requested there.
MavenTargetDependencyEditorTest.testAddMavenLocationrandomly fails with:i.e. the value typed into the first cell of the new row is lost.
I could not reproduce this one locally, so this is an attempt based on reading the code:
robot.text(0), which silently returns the location label of the wizard when no cell editor is active.The test now processes the pending UI events before editing a cell, and looks for the cell editor in the table only, so if the editor cannot be activated it fails with a clear message instead of typing into another field.
Testing
MavenTargetDependencyEditorTestpasses locally on Linux (9/9, three runs in a row) and passed on the three platforms and on Jenkins as part of #2265. Since the failure is random, the real check is whether it stops showing up on CI.🤖 Generated with Claude Code
https://claude.ai/code/session_01SscofYwGFw413Xrn8R2AUq