Repository navigation
tools/paradee: pass the ty type-check and editorconfig - #69
Merged
lalalune merged 1 commit intoOct 14, 2026
Merged
Conversation
- HPARAMS in the converter holds ints, floats and lists; annotate it as dict[str, Any] so ty does not infer a union for every lookup. - The reference dumper imports kokoro, misaki and espeakng_loader, which CI does not install; give tools/paradee/tools the same ty override as tools/kokoro/tools. - Final newline in kokoro-decoder-front.h (missing before this PR too). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 14, 2026
lalalune
added a commit
that referenced
this pull request
Oct 14, 2026
The converter writes its own git blob SHA-1 into the GGUF metadata (paradee.converter.git_blob_sha1). Commit ad8cf2e (#69) changed the converter for the ty type check. The blob changed, so the output changed too, but pins.json still pins the output of the old converter. Because of this, convert_paradee_pt_to_gguf.py --check-output fails at main, and the eliza paradee-voice build stops at the GGUF step. The new output has the same 603 tensors with the same bytes. Only the paradee.converter.git_blob_sha1 value is different (08ed165 to b8396ff). The size does not change. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #64. This commit was pushed to the #64 branch after #64 had already been merged, so it was not included.
HPARAMSholds ints, floats and lists. It is now annotated asdict[str, Any]; without that, ty (python-type-check.yml, ty 0.0.35) reports 29 errors intools/paradee/convert_paradee_pt_to_gguf.py.tools/paradee/tools/dump_paradee_reference.pyimports kokoro, misaki and espeakng_loader. Those run only in the pinned reference environment, not in CI.ty.tomlnow givestools/paradee/tools/**the same unresolved-import override thattools/kokoro/tools/**has.tools/kokoro/include/kokoro-decoder-front.h. It was already missing before tools/paradee: native Paradee-8M v1.0 TTS with phase lock and PyTorch parity gate #64, and editorconfig-checker flags it.Checked locally:
uvx ty@0.0.35 check tools/paradeeleaves only the torch/numpy imports, which CI installs from requirements-all. editorconfig-checker passes on the files #64 changed. Merged-tree host build passesctest -R 'kokoro|paradee|eliza-inference|misaki'17/17.🤖 Generated with Claude Code