Repository navigation
Conversation
- tagger.cpp used std::all_of without <algorithm>; GCC and the Windows clang toolchains reject it. Include <algorithm> in every misaki-g2p and parakeet source that uses std::min/std::max/std::all_of. - GCC ignores [[maybe_unused]] on a non-static data member and -Werror=attributes turned that into an error in misaki-internal.h. Drop the attribute and reference data_dir_ in the no-espeak path so clang's -Wunused-private-field stays quiet. - lexicon.cpp munmap cast dropped const via a C cast (-Wcast-qual). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
x86_64 only had the scalar tier, which runs the encoder below real time and leaves ASR on x86_64 Android emulator images unusable. pk-kernels-avx2.cpp adds decode (PSHUFB nibble lookup), the 8-row tile (VPMADDWD on int16-widened straight and half-swapped token pairs, the same scheme as the dotprod tier) and the decoder matvec. Widening to int16 keeps every int8 product exact, so the tier is bit-identical to scalar for any input. The file is built with -mavx2 (/arch:AVX2) and entered only after CPUID AVX2 plus XGETBV YMM state; PK_KERNEL=avx2 / --kernel avx2 force it. The kernel test now also runs 200 random full-range int8 tile and matvec cases (including the all -128 corner) against scalar for every tier. CMake no longer passes the ARM -march flags to an x86_64 build on an Apple silicon host (CMAKE_OSX_ARCHITECTURES=x86_64). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
documentation
Member
Author
|
Closing: this was a CI probe for #75, which is now merged (cc45e94). With #74 underneath, every x64 build compiled the AVX2 tier, including MSVC with /arch:AVX2. test-parakeet-kernels passed on ggml-ci x64 high-perf and low-perf and on Windows cpu-x64, openblas-x64 and vulkan-x64. The only test failure was test-kokoro-layer-options, which this change does not touch. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI probe only, do not merge. It is #75 merged on top of #74 (misaki CI build fixes) so that GCC, Windows and the Linux x86_64
test-parakeet-kernelsrun reach the new AVX2 tier; on the base branch the build currently stops at misaki-g2p. I will close it once the results are in.This PR was prepared with AI assistance (Claude Code).
🤖 Generated with Claude Code