Skip to content

refactor(runtime): coordinate worker sleep across I/O sources - #33

Merged
thweetkomputer merged 1 commit into
mainfrom
refactor/worker-wait-coordination
Nov 11, 2026
Merged

thweetkomputer merged 1 commit into
mainfrom
refactor/worker-wait-coordination

Conversation

@thweetkomputer

Copy link
Copy Markdown
Contributor

Worker sleep previously delegated shared-ring progression and blocking to the selected network backend. This change makes the worker explicitly poll, submit, and wait on its single io_uring, so additional I/O sources can participate without each facade driving the ring.

  • Split DPDK waiting into notification preparation, idle checks, deadline selection, and cleanup. Network Poll/Flush advances only native network work.
  • Apply the ownership boundary to ordinary scheduling, busy polling, shutdown rounds, and idle rechecks. Preserve mailbox wake_seq and DPDK parked handshakes, MSG_RING/eventfd wakes, FreeBSD deadlines, explicit DPDK poll mode, and SPDK outstanding-I/O sleep vetoes.
  • Clean up prepared notifications and parked state on early exits and errors. Strengthen DPDK parked publication with an acquire/release exchange.
  • Consolidate architecture documentation and document interface lifecycle contracts.

This is stage 1 of general RC/RDMA support. It introduces no RDMA library dependency or application protocol/buffer-pool changes.

Validation:

  • Kernel build: 110/110 CTest cases passed.
  • DPDK/SPDK build: 164/164 CTest cases passed.
  • Deterministic regressions cover publication after empty checks and before blocking, stop races, RX/TX software queues, notification cleanup, deadlines, deferred submissions, facade isolation, and busy polling.
  • clang-format 23.1.1 and git diff --check passed.

DPDK validation uses virtual devices and fault injection; physical NIC interrupt behavior was not validated.

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 016553d2-a4ea-4da0-9627-7b93bf5cb515
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Make the worker explicitly poll, submit and wait on its shared io_uring. Network facades advance only native network work. Split DPDK notification preparation, idle checks, deadline selection and cleanup from blocking, preserving publication handshakes, polling vetoes and stop handling.

Validate with 110 kernel-backend and 164 bypass-build CTest cases, including deterministic wake races, facade isolation, busy polling and SPDK pending-I/O checks. Consolidate architecture and interface contracts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant