Skip to content

Use X-forward base frames for pinch and parallel grippers - #147

Open
stevenaya wants to merge 3 commits into
enactic:mainfrom
stevenaya:refactor/gripper-base-frames
Open

stevenaya wants to merge 3 commits into
enactic:mainfrom
stevenaya:refactor/gripper-base-frames

Conversation

@stevenaya

Copy link
Copy Markdown
Contributor

Changes

Give the pinch and parallel-link grippers an X-forward base frame for standalone use. Keep each mounting origin fixed and compensate the rotation in the robot presets so the assembled geometry and motion stay unchanged.

Component Original forward direction Base-coordinate conversion Installation compensation
Pinch gripper −Z Y: −90° Y: +90°
Parallel-link gripper +Z Y: +90° Y: −90°
  • Update base-owned visual, collision and inertial origins, directly attached joint origins, and applicable reference points. Mesh files and inertia tensor values are unchanged; the inertial frames rotate with the coordinate conversion.
  • Update V1, V2 and mobile-example presets, including disabled gripper entries.
  • Preserve finger joint axes, limits, mimic relations, control declarations and the existing empty-link folding behavior. The assembled frames and TCP poses remain unchanged.

Validation

  • All 35 existing tests pass; no test or common-macro changes in the final diff.
  • Compare 175 V2/mobile poses and 150 V1 poses against the pre-change models, including joint-limit endpoints and randomized configurations. World-space visual, collision, inertial and reference transforms, joint axes and control declarations agree to floating-point precision.
  • Standalone and assembled models inspected in RViz with movable-joint TF axes enabled.

Copilot AI balanced review requested due to automatic review settings November 20, 2026 21:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

This branch was successfully deployed

1 active deployment
release — 10ad457d Deployed Nov 20, 2026 by stevenaya via Publish #541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants