Repository navigation
Send Keyring's emails from the package instead of publishing them - #83
Merged
Merged
Conversation
…nstead of publishing them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An install copied 25 files into the app; Fortify's copies 7. The 18 extra were Keyring's notification classes, which most apps never edit.
Keyring\Notificationsand are sent from the start.clone_suspectedstays off until an app turns it on, as before.Keyring::notifications([...])swaps one for the app's own class, ornullturns it off.SecurityNotice::toMailUsing()writes every security notice from the app's own template, which is what editing the publishedSecurityNoticeused to be for.--emailsand--no-emailsare gone) and the published provider loses its 17-line list.Apps that already register their own classes keep working: the list still overrides.
To test:
vendor/bin/pest --parallel, thenvendor/bin/pest tests/Feature/CommandsTest.phpon its own, since the installer tests skip in parallel.