Skip to content

Send Keyring's emails from the package instead of publishing them - #83

Merged
entity merged 1 commit into
mainfrom
refactor/ship-notifications-in-package
Nov 11, 2026
Merged

entity merged 1 commit into
mainfrom
refactor/ship-notifications-in-package

Conversation

@entity

@entity entity commented Nov 11, 2026

Copy link
Copy Markdown
Owner

An install copied 25 files into the app; Fortify's copies 7. The 18 extra were Keyring's notification classes, which most apps never edit.

  • The notifications now live in Keyring\Notifications and are sent from the start. clone_suspected stays off until an app turns it on, as before.
  • Keyring::notifications([...]) swaps one for the app's own class, or null turns it off.
  • SecurityNotice::toMailUsing() writes every security notice from the app's own template, which is what editing the published SecurityNotice used to be for.
  • The installer no longer asks about emails (--emails and --no-emails are gone) and the published provider loses its 17-line list.

Apps that already register their own classes keep working: the list still overrides.

To test: vendor/bin/pest --parallel, then vendor/bin/pest tests/Feature/CommandsTest.php on its own, since the installer tests skip in parallel.

@entity
entity merged commit 73a3ac5 into main Nov 11, 2026
0 of 5 checks passed
@entity
entity deleted the refactor/ship-notifications-in-package branch November 11, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant