Repository navigation
Close the third standards check's gaps and default to a second factor - #84
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the third pass against OWASP ASVS 5.0.0, the cheat sheets and NIST SP 800-63B-4 found, fixed.
Behaviour
keyring:installnow defaults to an authenticator app that every user must set up (ASVS 6.3.3, and Fortify offers 2FA out of the box).--factor=none, or unticking it, gives the password alone.session_resumed, with aSessionResumedevent. It was the one way a browser got signed in with nothing in the log.Cross-Origin-Opener-Policy: same-origin-allow-popupsunless the app sends its own (ASVS 3.4.8).Docs
Left as documented deviations: the TOTP window of one step (6.5.5), NFC normalisation (6.2.8), and a disabled account's sessions ending at next use (7.4.2).
GitHub Actions can't start jobs on this account right now (billing), so I ran each job locally: SQLite 1,679 passed, PostgreSQL 1,704 + 11 concurrency, lowest dependencies 1,704, Pint, Rector and both PHPStan configs clean. MySQL is noted in a comment.