Repository navigation
Fix what the fourth security audit confirmed - #88
Merged
Merged
Conversation
…over a hash the app won't check
…row around a change a session makes
…efused challenge against nothing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A full audit of
725939dconfirmed 21 issues, one medium and twenty low. This fixes all of them, each with a regression test, and hardens the code behind the two it left open.The medium one: a sign-in method saved by a request already under way while an email change is being undone could survive the undo, and still sign in afterwards. An undo now looks again once it has ended the sessions, and saving a sign-in method or asking for an email change re-checks its session under the lock a sign-out takes.
Changes in behaviour, also in
UPGRADE.md:keyring_sessionshas auser_typecolumn, so two user models with the same IDs no longer share sessions.timeboxdefaults to 500ms, up from 250ms, and now covers refused password resets. A refusal that outruns it is logged.sessions.end_on_lapse, a mid-session risk step-up signs the session out.All five CI jobs passed locally with
bin/ci, including 17 two-process race tests on PostgreSQL and MySQL.