Repository navigation
Release dry check: all secrets checked by name; preflight checks bundle id and display name - #164
Merged
Merged
Conversation
… id and display name Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCgWWsrZ4EvHNNNTAe7RC1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comes from a dry check of the release path before the first v1.0.0 tag. Two small fixes, no secrets touched.
Part of #28
Changes
release.yml: the secret check covers all eight. Before, it checked onlyASC_KEY_P8and the two.p12s. A missingDEVELOPMENT_TEAM,ASC_KEY_ID,ASC_ISSUER_IDor.p12password passed that step and then failed later in signing or the upload, with a less clear error. The step now checks each secret by name, never reading a value, and lists the missing ones:::error::Missing release secrets: ASC_ISSUER_ID DIST_CERT_PASSWORD. Add them, or give this repository access to the org secrets…preflight.shchecks two more things:CFBundleIdentifierisdev.ericdahl.ControllerBridge, the App Store Connect record's id, or$BUNDLE_ID, which the workflow sets.CFBundleDisplayNameis set and not an unexpanded$(…). It's DeckBridge since Display name: DeckBridge (hold until the name is reserved) #161.Tests
scripts/test-preflight.sh: the good fake app now has a display name. New failing cases for a wrong bundle id and a missingCFBundleDisplayNamewere red first, then green. All preflight tests pass.actionlintis clean.MARKETING_VERSION=1.0.0,CURRENT_PROJECT_VERSION=42.1): every check passes, including bundle iddev.ericdahl.ControllerBridgeand display name DeckBridge.🤖 Generated with Claude Code
https://claude.ai/code/session_01VCgWWsrZ4EvHNNNTAe7RC1