Repository navigation
fix(parser): keep backslash-escaped $ literal in unquoted words - #2563
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 79f40ae | Commit Preview URL Branch Preview URL |
Oct 07 2026, 02:13 PM |
3 tasks done
chaliy
force-pushed
the
claude/escaped-dollar
branch
from
October 7, 2026 13:42
a715620 to
e5b6f8f
Compare
chaliy
force-pushed
the
claude/escaped-dollar
branch
from
October 7, 2026 14:11
e5b6f8f to
79f40ae
Compare
chaliy
added a commit
that referenced
this pull request
Oct 7, 2026
<!-- ccr-projects-attribution: {"github_login":"chaliy"} -->
_Requested by **Михайло** · [project
thread](https://claude.ai/code/project/chan_019YEkBJuZMHJdXrjom86cGX?thread=cmsg_019YEkBJuZMHJdXrjom86cGX6hNmzgZPpfCgsgRMptbhdM)_
Stacked on #2563 (retargets to main when that merges).
## What changed
Quoted or backslash-escaped glob characters are literal, as in bash:
- Words: `a\*`, `a"*"` and `a'?'` no longer glob.
- `case` and `[[ == ]]` patterns: `"$x"`, `'a*'`, `a\*` and `\[s\]`
match literally.
- Mixed words: `"*"zz*` with no match prints `*zz*` (the internal
escapes used to leak). `"$x"zz*` reads `$x`, not `$xzz`.
- Single-quoted prefixes: `'a'$x` expands and `'a'*` globs. Both used to
be literal.
- `a{1,2}"*"` still brace-expands.
## Why
These are fidelity bugs from step 1 of the roadmap. A `case` or `[[ ]]`
on a quoted variable that holds `*`, `?` or `[` took the wrong branch.
## Before
```
$ cd /tmp/x && touch ab ac 'a*b' axb
$ echo a\* ; echo "*"zz* ; x='a*'; echo "$x"zz*
ab ac
\*zz*
a*b axb
$ case ab in "$x") echo glob;; *) echo literal;; esac
glob
```
## After
```
a*
*zz*
a*zz*
literal
```
The new spec `escaped-glob.test.sh` (6 cases) matches real bash.
## Risk
Medium, because it touches the lexer's word classification.
- The `QuotedGlobWord` convention (quoted glob characters
backslash-escaped) now covers `read_word` and single-quoted words, with
quote markers.
- `expand_word` unescapes for non-glob uses. Assignments and script
analysis unescape literal parts.
- Known gap: data from an unquoted expansion in such a word loses `\`
before glob characters when nothing matches.
- Documented in `knowledge/foundations/parser.md`.
## Checklist
- [x] Failing spec first, compared with bash
- [x] `cargo test -p bashkit --lib`, integration tests, clippy, fmt
- [x] knowledge updated
https://claude.ai/code/session_019aFikmptPc91Fj4N2iDXQA
---
_Generated by [Claude
Code](https://claude.ai/code/session_019aFikmptPc91Fj4N2iDXQA)_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Михайло · project thread
What changed
A backslash outside quotes now keeps
$and`literal in unquoted words. The lexer emits the same NUL literal marker it already uses for"\$", soparse_wordno longer starts an expansion there.Why
echo \$HOMEexpanded the variable. Scripts that generate other scripts (printf '%s\n' \$1,x=\$PATH) got the wrong text.Before
After
New spec
escaped-dollar.test.sh(4 cases) matches real bash; 3 of them failed before the change.Risk
Low. One lexer branch; the sentinel is already handled everywhere
parse_wordconsumes words.Checklist
cargo test -p bashkit --lib, integration testshttps://claude.ai/code/session_019aFikmptPc91Fj4N2iDXQA
Generated by Claude Code