Skip to content

[build-tools] Forward network capture through local egress - #4598

Merged
gwdp merged 2 commits into
mainfrom
gwdp/serve-sim-capture-egress-handoff
Oct 20, 2026
Merged

gwdp merged 2 commits into
mainfrom
gwdp/serve-sim-capture-egress-handoff

Conversation

@gwdp

@gwdp gwdp commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Why

Send captured Simulator traffic through the developer's local egress proxy.

How

  • Pass the existing handoff port to serve-sim's --network-capture-proxy; Android skips the handoff.

Release serve-sim with capture proxy support before deploying this worker change.

Test Plan

  • Codex ran 166 focused host/session tests, typecheck, changed-file lint and formatting after removing the unused host override. Independent review found no remaining issue. CI and fresh Devin analysis are pending on a6c2e5ae.
  • Earlier local launch E2E passed: Universe-generated steps through build-tools download/install/start to pinned serve-sim on a real iOS Simulator. Verified one app start, arguments and deep link. Cloud calls used loopback adapters; hosted and current-head device runs remain pending.
  • Earlier pinned Tart builds also passed capture through real local egress. That run predates this head.

Authorship and LLM use

Gabe wrote the initial session implementation and guided the design. Codex extracted the proxy forwarding. AI review covered the earlier combined flow. Gabe reviewed the final changes.

@gwdp
gwdp force-pushed the gwdp/serve-sim-capture-egress-handoff branch from a0575b1 to bfea5f8 Compare October 10, 2026 00:17
@gwdp

This comment has been minimized.

@codecov

codecov Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.29%. Comparing base (5ec3d84) to head (21feac8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4598      +/-   ##
==========================================
+ Coverage   75.29%   75.29%   +0.01%     
==========================================
  Files        1053     1053              
  Lines       52148    52153       +5     
  Branches    11387    11391       +4     
==========================================
+ Hits        39260    39264       +4     
- Misses      11900    11901       +1     
  Partials      988      988              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gwdp
gwdp added this pull request to stack #4599 October 10, 2026 00:26
@gwdp
gwdp removed this pull request from stack #4599 October 10, 2026 08:38
@gwdp
gwdp force-pushed the gwdp/serve-sim-capture-egress-handoff branch from bfea5f8 to 810a391 Compare October 10, 2026 08:40
@gwdp
gwdp changed the base branch from gwdp/serve-sim-argent-logs to gwdp/serve-sim-appium-startup October 10, 2026 08:40
@gwdp
gwdp added this pull request to stack #4604 October 10, 2026 08:40
@gwdp

This comment has been minimized.

@gwdp
gwdp force-pushed the gwdp/serve-sim-capture-egress-handoff branch from 810a391 to b952ad4 Compare October 10, 2026 16:25
@gwdp

This comment has been minimized.

@gwdp
gwdp force-pushed the gwdp/serve-sim-capture-egress-handoff branch 2 times, most recently from 88e0a45 to ab6d093 Compare October 10, 2026 16:53
@gwdp
gwdp removed this pull request from stack #4604 October 10, 2026 16:54
@gwdp
gwdp added this pull request to stack #4606 October 10, 2026 16:55
@gwdp

This comment has been minimized.

@gwdp
gwdp force-pushed the gwdp/serve-sim-capture-egress-handoff branch 3 times, most recently from 8507c7b to b962ad1 Compare October 10, 2026 18:18
@gwdp
gwdp force-pushed the gwdp/serve-sim-capture-egress-handoff branch 2 times, most recently from b42f129 to e56db23 Compare October 10, 2026 18:50
@gwdp

This comment has been minimized.

@gwdp
gwdp force-pushed the gwdp/serve-sim-capture-egress-handoff branch from e56db23 to dec080c Compare October 10, 2026 20:06
@gwdp

gwdp commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author

Codex removed the unused caller-supplied capture proxy override in a6c2e5ae0e76e4da6c5637054f181629a27663a8. Automatic iOS local-egress handoff forwarding is retained; Android still skips the handoff. The cleanup removes 39 net lines. Codex ran 166 focused host/session tests, typecheck, changed-file lint and formatting; all passed. Independent source review found no remaining issue. No new device or hosted acceptance was run.

— Codex

@gwdp
gwdp force-pushed the gwdp/serve-sim-capture-egress-handoff branch from 534defa to 5ecb2d1 Compare October 15, 2026 16:28
@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

devin-ai-integration[bot]

This comment was marked as resolved.

@gwdp
gwdp force-pushed the gwdp/serve-sim-capture-egress-handoff branch from 5ecb2d1 to 018580d Compare October 15, 2026 18:00
@gwdp
gwdp force-pushed the gwdp/serve-sim-capture-egress-handoff branch from 018580d to 56acba8 Compare October 15, 2026 18:24
@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@gwdp
gwdp force-pushed the gwdp/serve-sim-capture-egress-handoff branch from 56acba8 to 403c126 Compare October 15, 2026 18:38
@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@gwdp
gwdp requested a review from szdziedzic October 15, 2026 19:33
@gwdp
gwdp marked this pull request as ready for review October 15, 2026 19:33
@gwdp
gwdp removed this pull request from stack #4606 October 17, 2026 01:44
@gwdp
gwdp added this pull request to stack #4671 October 17, 2026 01:44
Base automatically changed from gwdp/serve-sim-appium-startup to main October 20, 2026 02:12
gwdp and others added 2 commits October 19, 2026 19:47
Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
@gwdp
gwdp force-pushed the gwdp/serve-sim-capture-egress-handoff branch from a6c2e5a to 21feac8 Compare October 20, 2026 02:48
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding a changeset!

@gwdp
gwdp merged commit c0d3f4f into main Oct 20, 2026
10 checks passed
@gwdp
gwdp deleted the gwdp/serve-sim-capture-egress-handoff branch October 20, 2026 03:46
AndrewSouthpaw added a commit to AndrewSouthpaw/eas-cli that referenced this pull request Oct 22, 2026
…t-dirs

* upstream/main: (128 commits)
  [build-tools] stop logging workflow hook parsing in build logs (expo#4717)
  [build-tools] retry download_build network failures and report their cause (expo#4690)
  [eas-cli][build-tools] Bump Node.js to 22.23.4 (expo#4714)
  [eas-cli] make command descriptions lowercase without trailing periods (expo#4385)
  [build-tools] Add `max_duration_seconds` to sandboxes (expo#4702)
  [eas-cli] Show simulator session errors in simulator:get (expo#4694)
  [eas-cli] Show why a simulator session failed to start (expo#4693)
  [worker] Mask secrets in every field of uploaded log records (expo#4698)
  [eas-build-job][build-tools] Check Android launch inputs before the session starts (expo#4696)
  bump STAGING and PRODUCTION to 25.3.0 in cli-versions.json
  v25.3.0
  [eas-cli] Add --system-image to eas simulator:start (expo#4500)
  [build-tools] Wait up to five minutes for Google Play to process an uploaded bundle (expo#4700)
  [build-tools] Quote Android launch arguments for the device shell (expo#4695)
  [build-tools] Forward network capture through local egress (expo#4598)
  [build-tools] Let serve-sim start the iOS Simulator for Appium (expo#4603)
  [build-tools] Let serve-sim start the iOS Simulator for Argent (expo#4602)
  [build-tools] Upload iOS Simulator session screen recording metadata (expo#4689)
  [build-tools] Reset the session idle timer on serve-sim preview input (expo#4691)
  [eas-cli] Add a checkout prompt experiment to the Free plan build limit error (expo#4633)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants