Repository navigation
[build-tools] Let serve-sim start the iOS Simulator for agent-device - #4544
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4544 +/- ##
==========================================
+ Coverage 74.79% 74.81% +0.02%
==========================================
Files 1039 1039
Lines 51104 51135 +31
Branches 11130 11140 +10
==========================================
+ Hits 38217 38250 +33
+ Misses 11896 11894 -2
Partials 991 991 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
aca69f5 to
e589453
Compare
This comment has been minimized.
This comment has been minimized.
e589453 to
9f038b4
Compare
9f038b4 to
5cad245
Compare
5cad245 to
d982e75
Compare
d982e75 to
238427d
Compare
238427d to
7e309fd
Compare
This comment has been minimized.
This comment has been minimized.
7e309fd to
60f377f
Compare
6aa2150 to
2adc5e8
Compare
This comment has been minimized.
This comment has been minimized.
266aece to
c8e7f58
Compare
c8e7f58 to
472e5f5
Compare
|
Codex rebased this stack on Clarified the existing benchmark paragraph: agent-device already overlaps startup tasks, and slower native installation offset the earlier start in that measured batch. Existing timings and evidence boundaries are unchanged. Gabe confirmed review of the final changes at — Codex |
472e5f5 to
b462637
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
b462637 to
af09740
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
af09740 to
84a2d58
Compare
|
Rebased onto main Codex resolved the overlaps with main's private-preview, iframe and CORS changes, preserving those settings alongside serve-sim startup. Both regression test sets remain; no unrelated source changes. 434 focused tests, typecheck across all 13 packages, full-repository lint and formatting pass. Independent Codex and Opus reviews found no rebase regression. Fresh CI is pending; no new hosted/device run was performed for this rebase. — Codex |
|
✅ Thank you for adding a changeset! |
Why
Boot the Simulator while the app downloads, and let serve-sim install and launch it for agent-device sessions.
How
Release serve-sim with the app-control API before deploying this worker change. Android keeps its existing path.
Test Plan
af09740b. Codex ran 406 focused tests after the main rebase; typecheck, changed-file lint and formatting passed.0.7.0-canary-20261009-782fe97; the app reached its HTTP origin. Guarded acceptance on this head is pending.Cold startup benchmark
Agent-device already overlaps boot, download and daemon startup on main, so there was less new parallel work to unlock than for Argent/Appium. In these trials, the fixture downloaded in milliseconds and native installation took longer (12.29s → 15.34s median), offsetting the earlier install start. The cause of that extra installer work was not established.
Codex measured four alternating pairs per type on an initialized iPhone 17 Pro Simulator (iOS 26.4, Tart 6 CPU / 8 GiB), starting shut down with the app absent and packages cached. Timing runs from worker entry to local session reporting, using real controllers and native boot/install/launch with loopback cloud adapters.
This compares the completed startup stack
e0b7462against main4aca8b1, with the same pinned local serve-sim #260 build; it does not isolate this PR's contribution. Hosted dispatch and first browser frame were not measured.Savings are the median of paired differences, not the difference between the two arm medians. Individual pairs ranged from 1.51s slower to 5.29s faster. This sample does not establish a consistent speedup or a no-slowdown guarantee.
Authorship and LLM use
Gabe wrote the initial implementation and guided the design. Codex implemented and split the changes. AI review led to fixes for startup order and cleanup. Gabe reviewed the final changes.