Repository navigation
[build-tools] Let serve-sim start the iOS Simulator for Argent - #4602
Conversation
bb48740 to
d3212ae
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4602 +/- ##
==========================================
+ Coverage 75.23% 75.25% +0.02%
==========================================
Files 1053 1053
Lines 52000 52045 +45
Branches 11345 11357 +12
==========================================
+ Hits 39118 39162 +44
- Misses 11894 11895 +1
Partials 988 988 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
d3212ae to
d9a919c
Compare
This comment has been minimized.
This comment has been minimized.
d9a919c to
799b387
Compare
799b387 to
37b1e61
Compare
This comment has been minimized.
This comment has been minimized.
a915716 to
8231479
Compare
8231479 to
ec8a350
Compare
ec8a350 to
9ccab93
Compare
9ccab93 to
bceb555
Compare
This comment has been minimized.
This comment has been minimized.
bceb555 to
41b6fcd
Compare
This comment has been minimized.
This comment has been minimized.
0893061 to
959e9d7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
959e9d7 to
743e6eb
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
9715281 to
5a8640f
Compare
|
Rebased #4602 onto main Codex resolved the host-startup conflict by keeping main's private-preview, iframe and CORS settings alongside Argent's startup-failure handling. Both test sets are retained. 368 focused tests, typecheck across all 13 packages, full-repository lint and formatting pass. Opus found no rebase regression. Fresh CI is pending. No new hosted Argent run was performed for this rebase. — Codex |
Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
5a8640f to
b243c95
Compare
|
Rebased onto main at aae7d13; new head b243c95. All four reviewed worker patches are unchanged by range-diff. Codex ran 137 focused tests, typecheck, changed-file lint and formatting successfully. No new hosted or device run is claimed. Existing Szymon approval predates this rebase. Deploy this worker before enabling Universe #32360; verify the production worker and cache canary before activation. /devin review — Codex |
|
✅ Thank you for adding a changeset! |
|
/devin review Please review exact rebased head b243c95, especially parallel Argent/Simulator startup failure handling and compatibility with prepared iOS and Android workflows. The four worker patches are unchanged by range-diff. — Codex |
…t-dirs * upstream/main: (128 commits) [build-tools] stop logging workflow hook parsing in build logs (expo#4717) [build-tools] retry download_build network failures and report their cause (expo#4690) [eas-cli][build-tools] Bump Node.js to 22.23.4 (expo#4714) [eas-cli] make command descriptions lowercase without trailing periods (expo#4385) [build-tools] Add `max_duration_seconds` to sandboxes (expo#4702) [eas-cli] Show simulator session errors in simulator:get (expo#4694) [eas-cli] Show why a simulator session failed to start (expo#4693) [worker] Mask secrets in every field of uploaded log records (expo#4698) [eas-build-job][build-tools] Check Android launch inputs before the session starts (expo#4696) bump STAGING and PRODUCTION to 25.3.0 in cli-versions.json v25.3.0 [eas-cli] Add --system-image to eas simulator:start (expo#4500) [build-tools] Wait up to five minutes for Google Play to process an uploaded bundle (expo#4700) [build-tools] Quote Android launch arguments for the device shell (expo#4695) [build-tools] Forward network capture through local egress (expo#4598) [build-tools] Let serve-sim start the iOS Simulator for Appium (expo#4603) [build-tools] Let serve-sim start the iOS Simulator for Argent (expo#4602) [build-tools] Upload iOS Simulator session screen recording metadata (expo#4689) [build-tools] Reset the session idle timer on serve-sim preview input (expo#4691) [eas-cli] Add a checkout prompt experiment to the Free plan build limit error (expo#4633) ...
Why
Let serve-sim start the Simulator and app while Argent is being prepared.
How
Release compatible serve-sim, deploy the worker, then enable the new workflow inputs.
Test Plan
aae7d13ac; all four worker patches are unchanged. All 137 focused tests, typecheck, changed-file lint and formatting pass locally. Fresh CI and Devin review are pending.Cold startup benchmark
Codex measured four alternating pairs per type on an initialized iPhone 17 Pro Simulator (iOS 26.4, Tart 6 CPU / 8 GiB), starting shut down with the app absent and packages cached. Timing runs from worker entry to local session reporting, using real controllers and native boot/install/launch with loopback cloud adapters.
This compares the completed startup stack
e0b7462against main4aca8b1, with the same pinned local serve-sim #260 build; it does not isolate this PR's contribution. Hosted dispatch and first browser frame were not measured.Savings are the median of paired differences, not the difference between the two arm medians. All four pairs were faster, by 7.21–14.01s.
Authorship and LLM use
Gabe wrote the initial implementation and guided the design. Codex implemented and split the changes. AI review led to fixes for startup order and cleanup. Gabe reviewed the final changes.