Repository navigation
[build-tools] Let serve-sim start the iOS Simulator for Appium - #4603
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4603 +/- ##
==========================================
+ Coverage 75.25% 75.29% +0.04%
==========================================
Files 1053 1053
Lines 52045 52148 +103
Branches 11357 11387 +30
==========================================
+ Hits 39162 39260 +98
- Misses 11895 11900 +5
Partials 988 988 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
875a7e9 to
1099760
Compare
This comment has been minimized.
This comment has been minimized.
56e2520 to
039acac
Compare
This comment has been minimized.
This comment has been minimized.
68549a3 to
5c38164
Compare
0688843 to
effd1f9
Compare
effd1f9 to
9f6e9f8
Compare
This comment has been minimized.
This comment has been minimized.
9f6e9f8 to
6b6c939
Compare
This comment has been minimized.
This comment has been minimized.
1bb3828 to
8f760c3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
98e7731 to
9c145a4
Compare
|
Codex rebased #4603 onto current main Resolved the conflicts by retaining main’s preview privacy, frame-ancestor/CORS settings and idle-timeout test coverage alongside Appium startup and failure cleanup. Added two focused tests for forwarding those preview settings on prepared and consolidated startup paths; both reject the missing-forwarding resolution. All 260 focused tests, typecheck, changed-file lint and formatting pass. No hosted Appium or device run was performed for this rebase; fresh CI and Devin review are pending. Upper stack branches were left unchanged. — Codex |
|
/devin review Please review rebased head — Codex |
|
✅ Thank you for adding a changeset! |
…t-dirs * upstream/main: (128 commits) [build-tools] stop logging workflow hook parsing in build logs (expo#4717) [build-tools] retry download_build network failures and report their cause (expo#4690) [eas-cli][build-tools] Bump Node.js to 22.23.4 (expo#4714) [eas-cli] make command descriptions lowercase without trailing periods (expo#4385) [build-tools] Add `max_duration_seconds` to sandboxes (expo#4702) [eas-cli] Show simulator session errors in simulator:get (expo#4694) [eas-cli] Show why a simulator session failed to start (expo#4693) [worker] Mask secrets in every field of uploaded log records (expo#4698) [eas-build-job][build-tools] Check Android launch inputs before the session starts (expo#4696) bump STAGING and PRODUCTION to 25.3.0 in cli-versions.json v25.3.0 [eas-cli] Add --system-image to eas simulator:start (expo#4500) [build-tools] Wait up to five minutes for Google Play to process an uploaded bundle (expo#4700) [build-tools] Quote Android launch arguments for the device shell (expo#4695) [build-tools] Forward network capture through local egress (expo#4598) [build-tools] Let serve-sim start the iOS Simulator for Appium (expo#4603) [build-tools] Let serve-sim start the iOS Simulator for Argent (expo#4602) [build-tools] Upload iOS Simulator session screen recording metadata (expo#4689) [build-tools] Reset the session idle timer on serve-sim preview input (expo#4691) [eas-cli] Add a checkout prompt experiment to the Free plan build limit error (expo#4633) ...
Why
Let serve-sim start the Simulator and app while Appium is being prepared.
How
Release compatible serve-sim, deploy the worker, then enable the new workflow inputs.
Test Plan
d0cb5a2d6, preserving preview privacy/CORS settings and idle-timeout coverage. All 260 focused tests, typecheck, changed-file lint and formatting pass locally, including two new privacy-forwarding regressions. CI passes on9c145a4, and the Devin review of that head reported no new findings.Cold startup benchmark
Codex measured four alternating pairs per type on an initialized iPhone 17 Pro Simulator (iOS 26.4, Tart 6 CPU / 8 GiB), starting shut down with the app absent and packages cached. Timing runs from worker entry to local session reporting, using real controllers and native boot/install/launch with loopback cloud adapters.
This compares the completed startup stack
e0b7462against main4aca8b1, with the same pinned local serve-sim #260 build; it does not isolate this PR's contribution. Hosted dispatch and first browser frame were not measured.Savings are the median of paired differences, not the difference between the two arm medians. All four pairs were faster, by 10.53–16.61s. Appium timing ends after server readiness; WDA session creation was not measured.
Authorship and LLM use
Gabe wrote the initial implementation and guided the design. Codex implemented and split the changes. AI review led to fixes for startup order and cleanup. Gabe reviewed the final diff after the rebase, including the conflict resolution, and can answer questions.
Generated with T3 Code, using Codex and Claude Code.