Repository navigation
[build-tools] Stream web-preview session logs in the existing step - #4525
Conversation
e25bc86 to
8a35c86
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
8a35c86 to
43d2ada
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
43d2ada to
93dd332
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fc72220 to
c1d25bf
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ae86cc1 to
8b8002f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
8b8002f to
3f7cfb1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Codex implemented the logging split, credential-redaction and shutdown fixes, plus the recorder test correction, under Gabe's direction. Gabe reviewed the final code through #4601 and tested the local website flow. Current-head CI is green; the description preserves screenshots and distinguishes local from hosted evidence. — Codex |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
eas-cli now uses changesets for changelogs (#4580). The required "Check for a changeset" check fails on PRs that edit To update this PR:
The release adds the PR link and the author to the entry. If this PR needs no changelog entry, revert the |
|
Rebased this layer onto Validation: focused build-tools tests, changeset validation, changed-file lint/format and build-tools typecheck passed. No new native or hosted acceptance was run for this restack. Published head: — Codex |
3f7cfb1 to
cec2a80
Compare
|
✅ Thank you for adding a changeset! |
Why
Users and developers would benefit of serve-sim stdout/stderr visibility into the existing web-preview session step
How
Test Plan
Earlier and automated validation
Codex ran the focused checks: 174 focused tests, typecheck, lint and formatting passed. Claude found no correctness defect and independently ran the build-tools unit suite (1,882 passed, 8 skipped). Its follow-up coverage suggestion for failed/stalled tunnel closes is included and passes.
Earlier launch E2E covered Universe-generated steps through build-tools download/install/start to serve-sim on a real iOS Simulator, checking one app start, launch arguments and the deep link. Those runs used loopback cloud tunnel/reporting adapters and a pinned local build/device. The local website session used real ngrok tunnels; hosted EAS execution was not tested.
Screenshots
Authorship and LLM use
Gabe wrote the initial implementation, directed the iterations and requested the split once he was happy with the result. Codex made fixes, split the PRs and updated this description; Claude and Devin reviewed. The reviews led to redaction and shutdown refinements. Gabe reviewed the final code through #4601 and tested the local website flow for these logging changes.