Skip to content

[build-tools] Stream web-preview session logs in the existing step - #4525

Merged
gwdp merged 1 commit into
mainfrom
gwdp/serve-sim-server-log-artifact
Oct 15, 2026
Merged

gwdp merged 1 commit into
mainfrom
gwdp/serve-sim-server-log-artifact

Conversation

@gwdp

@gwdp gwdp commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Why

Users and developers would benefit of serve-sim stdout/stderr visibility into the existing web-preview session step

How

  • Reuse the step logger without an extra preview phase.
  • Bound retained output, redact credentials, and drain shutdown output before cleanup
  • This is the shared foundation; agent-device, Appium and Argent logging follow in separate PRs on this stack

Test Plan

  • CI passed on the current head.
  • Tested the full stack locally with Gabe: EAS CLI, Universe API/workflow worker, build-tools and serve-sim 0.6.3 on an iPhone 17 Simulator. The website preview, remote Settings navigation and log ingestion worked.
Earlier and automated validation

Codex ran the focused checks: 174 focused tests, typecheck, lint and formatting passed. Claude found no correctness defect and independently ran the build-tools unit suite (1,882 passed, 8 skipped). Its follow-up coverage suggestion for failed/stalled tunnel closes is included and passes.

Earlier launch E2E covered Universe-generated steps through build-tools download/install/start to serve-sim on a real iOS Simulator, checking one app start, launch arguments and the deep link. Those runs used loopback cloud tunnel/reporting adapters and a pinned local build/device. The local website session used real ngrok tunnels; hosted EAS execution was not tested.

Screenshots Screenshot 2026-10-09 at 2 02 11 PM Screenshot 2026-10-09 at 2 02 16 PM

Authorship and LLM use

Gabe wrote the initial implementation, directed the iterations and requested the split once he was happy with the result. Codex made fixes, split the PRs and updated this description; Claude and Devin reviewed. The reviews led to redaction and shutdown refinements. Gabe reviewed the final code through #4601 and tested the local website flow for these logging changes.

@gwdp
gwdp force-pushed the gwdp/serve-sim-server-log-artifact branch from e25bc86 to 8a35c86 Compare October 2, 2026 07:42
@gwdp

This comment has been minimized.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

devin-ai-integration[bot]

This comment was marked as resolved.

@codecov

This comment has been minimized.

@gwdp
gwdp force-pushed the gwdp/serve-sim-server-log-artifact branch from 8a35c86 to 43d2ada Compare October 2, 2026 08:21
@gwdp gwdp changed the title [build-tools] Collect serve-sim server logs and supervise session tunnels [build-tools] Collect bounded serve-sim server logs Oct 2, 2026
@gwdp
gwdp changed the base branch from gwdp/network-capture-har-artifact to main October 2, 2026 08:21
@gwdp

This comment has been minimized.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@gwdp
gwdp force-pushed the gwdp/serve-sim-server-log-artifact branch from 43d2ada to 93dd332 Compare October 2, 2026 22:20
@gwdp gwdp changed the title [build-tools] Collect bounded serve-sim server logs [build-tools] Show live session and simulator preview logs Oct 2, 2026
@gwdp

This comment has been minimized.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

devin-ai-integration[bot]

This comment was marked as resolved.

@linear-code

This comment has been minimized.

@gwdp

This comment has been minimized.

@gwdp
gwdp force-pushed the gwdp/serve-sim-server-log-artifact branch from fc72220 to c1d25bf Compare October 6, 2026 00:00
@gwdp gwdp changed the title [build-tools] Show live session and simulator preview logs [build-tools] Run serve-sim and the controller in separate parallel log steps Oct 6, 2026
@gwdp

This comment has been minimized.

@gwdp gwdp changed the title [build-tools] Run serve-sim and the controller in separate parallel log steps [build-tools] Run serve-sim and the controller in separate parallel steps Oct 6, 2026
@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@gwdp gwdp changed the title [build-tools] Run serve-sim and the controller in separate parallel steps [build-tools] Stream web-preview session logs in the existing step Oct 9, 2026
@gwdp

This comment has been minimized.

@gwdp
gwdp force-pushed the gwdp/serve-sim-server-log-artifact branch 2 times, most recently from ae86cc1 to 8b8002f Compare October 9, 2026 19:52
@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@gwdp
gwdp force-pushed the gwdp/serve-sim-server-log-artifact branch from 8b8002f to 3f7cfb1 Compare October 9, 2026 20:01
@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@gwdp

gwdp commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author

Codex implemented the logging split, credential-redaction and shutdown fixes, plus the recorder test correction, under Gabe's direction. Gabe reviewed the final code through #4601 and tested the local website flow. Current-head CI is green; the description preserves screenshots and distinguishes local from hosted evidence.

— Codex

@gwdp
gwdp added this pull request to stack #4599 October 10, 2026 00:26
@gwdp
gwdp removed this pull request from stack #4599 October 10, 2026 08:38
@gwdp
gwdp added this pull request to stack #4604 October 10, 2026 08:40
@gwdp
gwdp removed this pull request from stack #4604 October 10, 2026 16:54
@gwdp
gwdp added this pull request to stack #4606 October 10, 2026 16:55
@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@douglowder

Copy link
Copy Markdown
Contributor

eas-cli now uses changesets for changelogs (#4580). The required "Check for a changeset" check fails on PRs that edit CHANGELOG.md.

To update this PR:

  1. Revert the changes to CHANGELOG.md.
  2. Run yarn changeset, select the changed packages and the bump type, and write the summary.
  3. Commit the new file in .changeset/.

The release adds the PR link and the author to the entry. If this PR needs no changelog entry, revert the CHANGELOG.md changes and add the "no changelog" label.

@gwdp

gwdp commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

Rebased this layer onto main and moved its release note from CHANGELOG.md into its own changeset. Current-main behavior was preserved.

Validation: focused build-tools tests, changeset validation, changed-file lint/format and build-tools typecheck passed. No new native or hosted acceptance was run for this restack.

Published head: cec2a8004fc94ea3d1dd78bfe2faa5fe4c049f28.

— Codex

@gwdp
gwdp force-pushed the gwdp/serve-sim-server-log-artifact branch from 3f7cfb1 to cec2a80 Compare October 15, 2026 01:21
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding a changeset!

@gwdp
gwdp merged commit 2630625 into main Oct 15, 2026
10 checks passed
@gwdp
gwdp deleted the gwdp/serve-sim-server-log-artifact branch October 15, 2026 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants