Skip to content

[eas-cli] Fix simulator control action help - #4681

Merged
gwdp merged 4 commits into
mainfrom
gwdp/simulator-control-help-fixes
Oct 27, 2026
Merged

gwdp merged 4 commits into
mainfrom
gwdp/simulator-control-help-fixes

Conversation

@gwdp

@gwdp gwdp commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Why

Action help bypassed oclif command lookup, producing the wrong command identity. Incomplete flags also showed a parse error instead of help.

Fixes #4674 and #4675. Independent follow-up split from #4679; targets main.

How

Test Plan

Codex ran 483 focused simulator/help tests, package typecheck, and changed-file lint/format checks. Five cases exercise real oclif discovery and lifecycle hooks; all five fail against the original implementation. Node 22/24 CI, coverage, and Devin checks pass on d23a4578c; no review threads are open.

After the rebase onto main, Claude Code ran the startAppiumRemoteSession tests: 33 passed. CI runs on the new head.

Codex also verified canonical/alias action help and incomplete-flag fallback against a real EAS session catalog, without changing native clipboard state. This used the unpublished local all-CLI integration dc6bfa8d6, containing this exact tip; its 711 combined simulator/help tests pass.

Authorship and LLM use

Gabe directed the fixes and requested separate PRs. Codex implemented, split, reviewed, and tested the change. After CI exposed a Node 22 harness timeout, Codex consolidated source loading into one bounded subprocess and repeated validation. Gabe then asked Claude Code to rebase this PR and add the Appium test fix.

Gabe reviewed the final diffs and can answer questions.

Generated with T3 Code, using Claude Code.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

devin-ai-integration[bot]

This comment was marked as outdated.

@codecov

codecov Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.59%. Comparing base (9315aeb) to head (55f02a6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4681      +/-   ##
==========================================
+ Coverage   75.59%   75.59%   +0.01%     
==========================================
  Files        1055     1055              
  Lines       52465    52469       +4     
  Branches    11470    11471       +1     
==========================================
+ Hits        39656    39660       +4     
  Misses      11829    11829              
  Partials      980      980              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

@gwdp

gwdp commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor Author

Codex contribution at d23a4578c: implemented and split the action-help fix, added five regression cases using real oclif discovery and lifecycle hooks, and corrected the Node 22 harness timeout. All five cases fail against the original implementation and pass here. The 483 focused simulator/help tests, package typecheck, changed-file lint/format checks, Node 22/24 CI, coverage, and Devin checks pass.

Gabe has reviewed the final changes at this head. The separate hosted QA evidence remains below.

— Codex

@devin-ai-integration

This comment has been minimized.

@gwdp

gwdp commented Oct 18, 2026

Copy link
Copy Markdown
Contributor Author

Hosted QA: Codex verified canonical/alias action help against a real session catalog and incomplete-flag fallback without changing native clipboard state. This used the local all-CLI integration dc6bfa8d6, which contains this exact tip and the import/path/app fixes. All 711 combined simulator/help tests pass locally; the integration merge remains unpublished.

— Codex

@gwdp
gwdp marked this pull request as ready for review October 19, 2026 04:49
@gwdp
gwdp requested a review from szdziedzic October 19, 2026 04:49
@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
packages/eas-cli/** @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

gwdp and others added 4 commits October 26, 2026 16:53
#4622 added this test while #4699 added appium:isHeadless to the iOS
default capabilities. Each PR passed CI without the other, so main fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@gwdp
gwdp force-pushed the gwdp/simulator-control-help-fixes branch from d23a457 to 55f02a6 Compare October 26, 2026 23:54
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding a changeset!

@gwdp
gwdp merged commit 82845de into main Oct 27, 2026
7 checks passed
@gwdp
gwdp deleted the gwdp/simulator-control-help-fixes branch October 27, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

simulator:control: action --help runs the command with id "simulatorcontrol"

2 participants