Repository navigation
[eas-cli] Fix simulator control action help - #4681
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4681 +/- ##
==========================================
+ Coverage 75.59% 75.59% +0.01%
==========================================
Files 1055 1055
Lines 52465 52469 +4
Branches 11470 11471 +1
==========================================
+ Hits 39656 39660 +4
Misses 11829 11829
Partials 980 980 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Codex contribution at Gabe has reviewed the final changes at this head. The separate hosted QA evidence remains below. — Codex |
This comment has been minimized.
This comment has been minimized.
|
Hosted QA: Codex verified canonical/alias action help against a real session catalog and incomplete-flag fallback without changing native clipboard state. This used the local all-CLI integration — Codex |
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
d23a457 to
55f02a6
Compare
|
✅ Thank you for adding a changeset! |
Why
Action help bypassed oclif command lookup, producing the wrong command identity. Incomplete flags also showed a parse error instead of help.
Fixes #4674 and #4675. Independent follow-up split from #4679; targets
main.How
config.runCommand('simulator:control', args)so oclif sets the canonical identity and runs its hooks.--outputor--idflags.main. [build-tools] Start Appium with the prepared Full Disk Access helper #4622 added the test, and [build-tools] Run Appium iOS sessions with a headless Simulator #4699 addedappium:isHeadlessto the iOS default capabilities. Each passed CI without the other, so the test onmainexpected the old capabilities. The test now expectsappium:isHeadlesson darwin.Test Plan
Codex ran 483 focused simulator/help tests, package typecheck, and changed-file lint/format checks. Five cases exercise real oclif discovery and lifecycle hooks; all five fail against the original implementation. Node 22/24 CI, coverage, and Devin checks pass on
d23a4578c; no review threads are open.After the rebase onto
main, Claude Code ran thestartAppiumRemoteSessiontests: 33 passed. CI runs on the new head.Codex also verified canonical/alias action help and incomplete-flag fallback against a real EAS session catalog, without changing native clipboard state. This used the unpublished local all-CLI integration
dc6bfa8d6, containing this exact tip; its 711 combined simulator/help tests pass.Authorship and LLM use
Gabe directed the fixes and requested separate PRs. Codex implemented, split, reviewed, and tested the change. After CI exposed a Node 22 harness timeout, Codex consolidated source loading into one bounded subprocess and repeated validation. Gabe then asked Claude Code to rebase this PR and add the Appium test fix.
Gabe reviewed the final diffs and can answer questions.
Generated with T3 Code, using Claude Code.