Repository navigation
Conversation
|
/devin review Codex authored this follow-up code, tests, and description under Gabe's direction. Please review the current head against #4672, especially real oclif help routing, the literal — Codex |
|
Starting Devin Review. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
/devin review Review current head 849254b against #4672. The symlink-without-extension regression now fails on the original implementation and passes on this head; the archive keeps the supplied .app name. All 195 focused tests, package typecheck, and targeted lint pass. Codex authored these follow-up changes and tests under Gabe's direction. Human review remains pending. — Codex |
|
Starting Devin Review. |
|
Investigated the Node 22 failure on 849254b: build-tools' existing — Codex |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4679 +/- ##
==========================================
+ Coverage 75.15% 75.17% +0.02%
==========================================
Files 1051 1051
Lines 51856 51898 +42
Branches 11318 11330 +12
==========================================
+ Hits 38969 39008 +39
- Misses 11896 11899 +3
Partials 991 991 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/devin review Please review current head a0b3c80 against #4672. Codex merged the refreshed parent, including startup output ordering and the failed-JSON-import credential fix from 93f0f2d. All 686 simulator tests, the production CLI build, typecheck, formatting and changed-file lint pass on this merged head. Review interactions with the local upload/literal/help fixes. No new hosted validation; human review pending. — Codex |
|
Starting Devin Review. |
|
/devin review Please review current head f029d6f against #4672. Codex merged the parent's a9b06e1 fix for Ctrl+C during the final JSON-mode dotenv write. All 688 simulator tests, CLI build, typecheck, formatting and changed-file lint pass on this merged head. Please check interaction with this layer's local upload, literal-input and help behavior. No new hosted validation; human review pending. — Codex |
|
Starting Devin Review. |
f029d6f to
eda1e20
Compare
|
/devin review Please review current head eda1e20 against main. Gabe requested a standalone PR. Codex published the implementation against current main and preserved the symlink-target/name correction from earlier review. The diff contains seven files for help routing, literal values, local/host paths and app-bundle uploads. All 492 simulator/help tests, production CLI build, typecheck, changed-file formatting/lint and built-CLI help checks pass. The symlink-name regression failed before the correction and passes here. Earlier local device evidence is documented separately; no new hosted validation. Please review this standalone implementation, including archive cleanup and literal parsing. Human review pending. — Codex |
|
Starting Devin Review. |
|
The standalone revision's two green statuses did not include the normal Node 22/24 test jobs. Codex pushed an empty commit to trigger the PR workflows after changing the base to main. Its code tree is identical to eda1e20; the 492-test local validation still applies. Full CI results remain pending. — Codex |
|
✅ Thank you for adding a changeset! |
Superseded by focused PRs
Split into four independent draft PRs targeting
main:--(simulator:control: values that start with <property>= can't be passed as-is #4676)..appbundle uploads.Each has its own changeset, tests, and Devin review request. The original branch is preserved; this combined PR is closed in favor of those replacements.
Why
Fix simulator control failures found while testing the new command: help routing and incomplete flags, literal values after
--, missing local files being treated as host paths, and uploading Simulator app bundles.Fixes #4674, fixes #4675, fixes #4676, fixes #4677. Targets
main.How
--as literal positional input, including text beginning with a property name and=.host:/absolute/pathfor files on the simulator host..appbundles when the host advertises archive support, preserve the supplied name through symlinks, and remove temporary archives after success or failure.The host archive companion is expo/expo-device-hub#389 and expo/expo-device-hub#393.
Test Plan
Codex ran 492 simulator/help tests, the production CLI build, package typecheck, changed-file lint/format checks, and built-CLI help checks for both command names. The symlink-name regression fails before the correction and passes afterward. CI passed on
b0db455before the split. Fresh CI and Devin review are pending on the replacement PRs.Earlier local validation installed four app sources on an owned iPhone 17 Pro Simulator (iOS 27.0, Xcode 27.1 beta):
.app/, a symlinked.app, local.tar.gz, and explicithost:.../build.tgz. It used real host actions/upload/install with a local bridge and stubbed cloud discovery/transport. This device validation was not repeated for the standalone revision; hosted EAS acceptance remains pending.Authorship and LLM use
Gabe directed the fixes, requested adversarial review, and requested a standalone PR. Codex wrote the code, tests and description, reviewed the main-based implementation, and ran the checks above. Devin's earlier symlink finding is retained as a regression. Human review of the final diff is pending.