Skip to content

Reject queryType=semantic with 400 - #96

Open
daplein wants to merge 1 commit into
feature23:mainfrom
daplein:feature/semantic-query-400
Open

daplein wants to merge 1 commit into
feature23:mainfrom
daplein:feature/semantic-query-400

Conversation

@daplein

@daplein daplein commented Oct 16, 2026

Copy link
Copy Markdown

Semantic ranking needs a hosted reranker and cannot be emulated. Today queryType=semantic silently runs as a plain query, so callers take lexical results for reranked ones. Return 400 with a clear message instead (POST and GET search).

Test: SemanticQueryIntegrationTests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@daplein
daplein marked this pull request as ready for review October 16, 2026 10:47
@daplein

daplein commented Oct 16, 2026

Copy link
Copy Markdown
Author

This PR is independent of #94, #95 and #97 (each branches off main), so it can be merged in any order. It is also the most optional of the four: it only turns a silent fallback to a plain query into a clear 400.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant