Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The envelope for unexpected faults stays covered by ErrorResponseTests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
daplein
marked this pull request as ready for review
October 16, 2026 10:47
Author
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An index's Lucene directory is only created on the first write, so searching, counting or getting from a freshly created index returned 500 (DirectoryNotFoundException). Azure answers an empty result (404 for a missing document). The searcher now falls back to an empty reader.
ErrorResponseIntegrationTests.UnexpectedFailure_ReturnsEnvelopeWithoutInternalDetailused this 500 as its trigger (its comment anticipated the fix) and is removed; the envelope for unexpected faults is still covered byErrorResponseTests.Test:
EmptyIndexIntegrationTests.