Repository navigation
app: a demo's hold on the panes survives a failed copy and a launch - #639
Merged
Merged
Conversation
- Nothing is saved while a demo holds the panes, whatever else happens (`Workbench.holding`): a copy that could not be made was swallowed, and the demo's panes saved over the person's. Where there is no copy, the end reads theirs back from disk, which nothing overwrote. - A demo started before the first rebuild restored last session's panes held the default tree, and the saved panes loaded mid-demo. That restore now waits for the demo to end. - Each document reopens into the pane it was in, recorded when the demo began, rather than the current one, so the arrangement put back does not depend on the layout's saved assignments. The demo test now starts from the person's own two panes and checks both, each with its document, after a demo that split the editor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fizzyedit/plans#30. Review follow-up to #623, which merged before these fixes.
What changes
Three findings from #623's review:
holdPanesswallowed a copy that couldn't be made, so nothing was held and the demo's panes were saved over the person'spanes.zon. Now aholdingflag stops every save while a demo has the window, whatever else happens. Where there is no copy, the end reads the person's arrangement back from disk, which nothing overwrote.SDK impact
Verified
zig build test-integration(81/81 steps, on currentmain). The demo test now starts from the person's own two panes: a file of theirs in one, the site's zip in the other. After a demo that splits the editor, both panes are back, each with its document, through a further rebuild.zig build,zig build check-web,scripts/check-fmt.sh.🤖 Generated with Claude Code