Repository navigation
ci: one script sets up a self-hosted worker box - #726
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04547ee8b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| busy && return 0 | ||
| kb=$(du -sk -- "$path" | cut -f1) |
There was a problem hiding this comment.
Keep cleanup mutually exclusive with runner jobs
When a queued Actions job starts after this busy check, the cleaner proceeds to du and then removes the cache while the new job may already be using it; measuring a large cache can make this race window substantial. Because the setup leaves the Actions listener running while enabling this timer, checking /proc is not sufficient synchronization—pause the listener or use a lock/job hook shared with runner jobs before deleting anything.
Useful? React with 👍 / 👎.
| if [ -f "$runner/.service" ]; then | ||
| run bash -c 'cd "$1" && ./svc.sh stop' _ "$runner" | ||
| fi |
There was a problem hiding this comment.
Restore the runner service when a rerun aborts
When reprovisioning an existing runner, any later transient failure—such as apt-get, a release lookup, or a download failing under set -e—exits after this stop without restarting the service, leaving the worker offline until someone notices and reruns or starts it manually. Install an exit trap after stopping the service, or delay the stop until the fallible preparation work has completed.
Useful? React with 👍 / 👎.
04547ee to
d7720ed
Compare
d7720ed to
185d60b
Compare
185d60b to
61ac3bd
Compare
Made by OpenAI Codex as a fizzy worker; Claude reviews it before it is marked ready.
Codex's report
Implemented runner setup, conservative cleanup with a daily timer, and the “Self-hosted runner” documentation.
Real Ubuntu provisioning still needs maintainer verification. SDK unchanged. No commits, pushes, or PR created.
🤖 Generated with Claude Code