Skip to content

ci: one script sets up a self-hosted worker box - #726

Merged
foxnne merged 1 commit into
mainfrom
ci/runner-setup
Oct 21, 2026
Merged

foxnne merged 1 commit into
mainfrom
ci/runner-setup

Conversation

@foxnne

@foxnne foxnne commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Made by OpenAI Codex as a fizzy worker; Claude reviews it before it is marked ready.

Codex's report

Implemented runner setup, conservative cleanup with a daily timer, and the “Self-hosted runner” documentation.

  • Passed: dry runs, token-redaction check, shellcheck, cleanup fixtures, native build, unit tests, web, SDK, lint, and tests-reached gates.
  • Format: equivalent check passed; exact script blocked by jj’s sandbox lock.
  • Integration: failed, 78/81 steps succeeded, with macOS watcher crashes.

Real Ubuntu provisioning still needs maintainer verification. SDK unchanged. No commits, pushes, or PR created.
🤖 Generated with Claude Code

@foxnne

foxnne commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T21:02:58.980083Z 04547ee Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 04547ee8b2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/runner-clean.sh
Comment on lines +53 to +54
busy && return 0
kb=$(du -sk -- "$path" | cut -f1)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep cleanup mutually exclusive with runner jobs

When a queued Actions job starts after this busy check, the cleaner proceeds to du and then removes the cache while the new job may already be using it; measuring a large cache can make this race window substantial. Because the setup leaves the Actions listener running while enabling this timer, checking /proc is not sufficient synchronization—pause the listener or use a lock/job hook shared with runner jobs before deleting anything.

Useful? React with 👍 / 👎.

Comment thread scripts/runner-setup.sh
Comment on lines +65 to +67
if [ -f "$runner/.service" ]; then
run bash -c 'cd "$1" && ./svc.sh stop' _ "$runner"
fi

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore the runner service when a rerun aborts

When reprovisioning an existing runner, any later transient failure—such as apt-get, a release lookup, or a download failing under set -e—exits after this stop without restarting the service, leaving the worker offline until someone notices and reruns or starts it manually. Install an exit trap after stopping the service, or delay the stop until the fallible preparation work has completed.

Useful? React with 👍 / 👎.

@foxnne
foxnne marked this pull request as ready for review October 20, 2026 22:32
@foxnne
foxnne added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit adff53d Oct 21, 2026
12 checks passed
@foxnne
foxnne deleted the ci/runner-setup branch October 21, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant