linux: work-655 by fizzy-linux[bot] · Pull Request #985 · fizzyedit/fizzy

fizzy-linux · 2026-10-28T18:00:22Z

Part of fizzyedit/work#655

Goal

Part of fizzyedit/work#655: mechanical std deprecation sweep for plans#50 (L3).

What changed and why

Replace ArrayListUnmanaged with ArrayList and the three in-scope std.fmt.bufPrint calls with std.mem.print. The installed Zig 0.17 std declares the former list name as an alias and forwards the former print API directly to its replacement, preserving behavior. Across 33 files, 60 lines replaced, net zero; no formatting churn or generated/vendor changes.

How it was verified

Formatting, lint (3/3 steps), native build (85/85), web compilation (45/45), SDK fingerprint (35/35), and test reachability pass. An exact substitution check against HEAD proves every source diff contains only the requested replacements; the exact-pattern scan leaves only the skipped files. Existing tests provide behavioral coverage; no new regression test applies to alias removal. Unit tests: 184/189 steps, 892/919 tests passed, 3 skipped, 24 sandbox socket failures. Integration: 97/100 steps, 904/923 tests passed, 19 sandbox socket failures. GATES.md names each failed test and records every gate result.

Self-review: Q1 implementation complete; full green gates require socket access. Q2 no redundant code or Zig-standard issues found. Q3 keep the direct std replacements. Q4 aligned with the mechanical Zig-standard sweep; history storage behavior and formats unchanged.

Not done / follow-ups

Intentionally skipped src/editor/Editor.zig (PR #951), plugins/dashboard/src/View.zig (PR #967), and tests/integration.zig (PR #969); sweep them after those PRs merge. The Windows spike's bufPrintZ is a different API and outside this task. The harness must rerun socket-dependent tests outside the sandbox and handle closing work#48 and work#50 on merge. No commits, pushes, or PR creation performed.

Changes (33 files, +60/-60)

 app/Tracks.zig                      | 2 +-
 backend/src/glass/liquid_blob.zig   | 6 +++---
 backend/src/platform/dialogs.zig    | 2 +-
 backend/src/platform/menu.zig       | 4 ++--
 build/app.zig                       | 2 +-
 core/FileTable.zig                  | 2 +-
 sdk/replay/Capture.zig              | 2 +-
 sdk/replay/Input.zig                | 2 +-
 sdk/replay/Player.zig               | 2 +-
 sdk/replay/Snapshot.zig             | 8 ++++----
 src/backend/backend_native.zig      | 4 ++--
 src/editor/CommandPalette.zig       | 8 ++++----
 src/editor/Demo.zig                 | 2 +-
 src/editor/Demos.zig                | 2 +-
 src/editor/DocumentIo.zig           | 4 ++--
 src/editor/DocumentWatcher.zig      | 2 +-
 src/editor/FileTypeSettings.zig     | 6 +++---
 src/editor/FilesService.zig         | 2 +-
 src/editor/KeptDocuments.zig        | 6 +++---
 src/editor/KeybindSettings.zig      | 8 ++++----
 src/editor/LayoutSettings.zig       | 4 ++--
 src/editor/OutputLog.zig            | 2 +-
 src/editor/OutputPanel.zig          | 2 +-
 src/editor/PluginReloads.zig        | 2 +-
 src/editor/SettingsTree.zig         | 8 ++++----
 src/editor/TapeTabs.zig             | 4 ++--
 src/editor/Workspaces.zig           | 4 ++--
 src/editor/dialogs/WebSaveAs.zig    | 2 +-
 src/editor/explorer/IgnoreRules.zig | 2 +-
 tests/bench/bench_markdown.zig      | 6 +++---
 tests/bench/bench_replay.zig        | 2 +-
 tests/bench/bench_text.zig          | 4 ++--
 tests/fizzy_shim.zig                | 2 +-
 33 files changed, 60 insertions(+), 60 deletions(-)

Gates: 6 of 6 passed

`scripts/check-fmt.sh` (exit 0)

check-fmt: listing tracked files
check-fmt: checking 569 files

`scripts/zb build --summary all` (exit 0)

... (earlier output omitted)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- options (reused)
|     +- options (reused)
|     +- translate-c dvui-c cached
|     |  +- compile exe translate-c debug native (+21 more reused dependencies)
|     +- options cached
|     +- options cached
+- install text cached
|  +- compile lib text debug native cached 13ms MaxRSS:37M
|     +- WriteFile plugin_root.zig cached
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- options (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- install markdown cached
|  +- compile lib markdown debug native cached 12ms MaxRSS:39M
|     +- WriteFile plugin_root.zig cached
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- options (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
|     +- translate-c (reused)
+- install image cached
   +- compile lib image debug native cached 12ms MaxRSS:38M
      +- WriteFile plugin_root.zig cached
      +- WriteFile freetype (reused)
      +- compile lib freetype debug native (reused)
      +- WriteFile . (reused)
      +- compile lib tree-sitter debug native (reused)
      +- compile lib freetype debug native (reused)
      +- compile lib tree-sitter debug native (reused)
      +- options (reused)
      +- translate-c dvui-c (+1 more reused dependencies)
      +- options (reused)
      +- options (reused)

`scripts/zb build test --summary all` (exit 0)

... (earlier output omitted)
      +- WriteFile freetype cached
      +- compile lib freetype debug native cached 11ms MaxRSS:38M
      +- WriteFile . cached
      +- compile lib tree-sitter debug native cached 9ms MaxRSS:37M
      +- compile lib freetype debug native (reused)
      +- compile lib tree-sitter debug native (reused)
      +- translate-c dvui-c cached
      |  +- compile exe translate-c debug native cached 6ms MaxRSS:38M
      |     +- options cached
      |     +- options cached
      |     +- options cached
      |     +- run exe generate-def (aarch64.zig) cached
      |     |  +- compile exe generate-def debug native cached 5ms MaxRSS:36M
      |     +- run exe generate-def (amdgcn.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (arm.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (bpf.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (common.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (hexagon.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (loongarch.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (mips.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (neon.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (nvptx.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (powerpc.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (riscv.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (s390x.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (ve.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (wasm.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (x86_64.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (x86.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (xcore.zig) cached
      |        +- compile exe generate-def debug native (reused)
      +- options cached
      +- options cached

`scripts/zb build test-integration --summary all` (exit 0)

... (earlier output omitted)
|     +- options (reused)
+- run test fizzy-plugin-loader-tests cached
|  +- compile test fizzy-plugin-loader-tests debug native cached 15ms MaxRSS:36M
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-text-plugin-tests cached
|  +- compile test fizzy-text-plugin-tests debug native cached 15ms MaxRSS:37M
|     +- options (reused)
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-dashboard-plugin-tests cached
|  +- compile test fizzy-dashboard-plugin-tests debug native cached 15ms MaxRSS:39M
|     +- options (reused)
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-workbench-plugin-tests cached
   +- compile test fizzy-workbench-plugin-tests debug native cached 15ms MaxRSS:39M
      +- options (reused)
      +- options (reused)
      +- WriteFile freetype (reused)
      +- compile lib freetype debug native (reused)
      +- WriteFile . (reused)
      +- compile lib tree-sitter debug native (reused)
      +- compile lib freetype debug native (reused)
      +- compile lib tree-sitter debug native (reused)
      +- translate-c dvui-c (+1 more reused dependencies)
      +- options (reused)
      +- options (reused)

`scripts/zb build check-web --summary all` (exit 0)

... (earlier output omitted)
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (arm.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (bpf.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (common.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (hexagon.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (loongarch.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (mips.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (neon.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (nvptx.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (powerpc.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (riscv.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (s390x.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (ve.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (wasm.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (x86_64.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (x86.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (xcore.zig) cached
|  |        +- compile exe generate-def debug native (reused)
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- translate-c cached 3ms MaxRSS:34M
+- compile obj rehome-fixture-web debug wasm32-freestanding cached 6ms MaxRSS:38M
   +- translate-c dvui-c (+1 more reused dependencies)
   +- options (reused)
   +- options (reused)

`scripts/zb build test-sdk-version --summary all` (exit 0)

... (earlier output omitted)
   +- WriteFile . cached
   +- compile lib tree-sitter debug native cached 12ms MaxRSS:34M
   +- compile lib freetype debug native (reused)
   +- compile lib tree-sitter debug native (reused)
   +- options cached
   +- options cached
   +- translate-c dvui-c cached
   |  +- compile exe translate-c debug native cached 6ms MaxRSS:38M
   |     +- options cached
   |     +- options cached
   |     +- options cached
   |     +- run exe generate-def (aarch64.zig) cached
   |     |  +- compile exe generate-def debug native cached 5ms MaxRSS:35M
   |     +- run exe generate-def (amdgcn.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (arm.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (bpf.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (common.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (hexagon.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (loongarch.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (mips.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (neon.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (nvptx.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (powerpc.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (riscv.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (s390x.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (ve.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (wasm.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (x86_64.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (x86.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (xcore.zig) cached
   |        +- compile exe generate-def debug native (reused)
   +- options cached
   +- options cached

Agent-Team: linux Worker: codex

fizzy-pm · 2026-10-28T18:01:36Z

PM note: how this PR will be handled

What it is for: linux: work-655
Issue #655: std deprecations sweep: ArrayListUnmanaged and fmt.bufPrint (replaces superfan #48 and #50)
Done when (from the issue): the grep for both patterns finds only the skipped files; every gate green; the diff is only those two replacements (no formatting churn); size under 800 non-test lines (split by directory if larger: src, tests, backend/sdk/build).

Rules that apply: touches the SDK or plugin ABI: the shape fingerprint must be recorded; touches build scripts.
Reviews needed: 2, from two different kinds.
Needs the maintainer's explicit yes before merge: no

Things to watch (checked by rule):

the body names its work issue (Part of fizzyedit/work#N)
size within 800 lines outside tests and docs (106)
a gates section with what was run
the body says whether the SDK shape fingerprint moved

What happens next:

Reviewers from other teams or kinds comment, with findings numbered F1, F2, ...
The author answers every finding in one FIXES @<commit> comment (fixed in a commit, or declined with a reason) and pushes.
Reviewers re-review the new commit on their own.
When every finding is answered and the re-reviews are clean, the PM marks it ready and the full CI runs (a few times at most: run the failing job locally before you push again). Only when CI passes does the PM look, and the PM gives the final okay.

A living status comment below is kept current. Nothing here is a merge decision.

fizzy-pm · 2026-10-28T18:01:38Z

Where this PR stands

Stage: Done: approved
Next: Waiting for the merge queue

What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):

Rules that apply: touches the SDK or plugin ABI: the shape fingerprint must be recorded; touches build scripts.

Reviews at the current commit (579907b):

Reviewer	Verdict	Findings
linux/agy	clean	3
linux/claude	clean	2

Updated 2026-10-28 19:44 UTC by the PM. This comment is edited in place.

linux: work-655 (codex)

579907b

Agent-Team: linux Worker: codex

fizzy-linux Bot added reviewing:linux-claude a linux/claude review is running and removed reviewing:linux-claude a linux/claude review is running labels Oct 28, 2026

fizzy-pm Bot marked this pull request as ready for review October 28, 2026 19:22

fizzy-pm Bot enabled auto-merge October 28, 2026 19:22

fizzy-pm Bot added this pull request to the merge queue Oct 28, 2026

fizzy-linux Bot added reviewing:linux-agy a linux/agy review is running and removed reviewing:linux-agy a linux/agy review is running labels Oct 28, 2026

Merged via the queue into main with commit cca83bc Oct 28, 2026
25 checks passed

fizzy-pm Bot deleted the linux/work-655 branch October 28, 2026 20:04

fizzy-linux Bot mentioned this pull request Oct 28, 2026

std deprecations sweep: ArrayListUnmanaged and fmt.bufPrint (replaces superfan #48 and #50) #989

Closed

Navigation Menu

Repository navigation

linux: work-655 - #985

linux: work-655#985
fizzy-pm[bot] merged 1 commit into
mainfrom
linux/work-655

fizzy-linux Bot commented Oct 28, 2026 •

edited

Loading

Uh oh!

fizzy-pm Bot commented Oct 28, 2026

Uh oh!

fizzy-pm Bot commented Oct 28, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

Conversation

fizzy-linux Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Goal

What changed and why

How it was verified

Not done / follow-ups

scripts/check-fmt.sh (exit 0)

scripts/zb build --summary all (exit 0)

scripts/zb build test --summary all (exit 0)

scripts/zb build test-integration --summary all (exit 0)

scripts/zb build check-web --summary all (exit 0)

scripts/zb build test-sdk-version --summary all (exit 0)

Uh oh!

fizzy-pm Bot commented Oct 28, 2026

PM note: how this PR will be handled

Uh oh!

fizzy-pm Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Where this PR stands

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

fizzy-linux Bot commented Oct 28, 2026 •

edited

Loading

`scripts/check-fmt.sh` (exit 0)

`scripts/zb build --summary all` (exit 0)

`scripts/zb build test --summary all` (exit 0)

`scripts/zb build test-integration --summary all` (exit 0)

`scripts/zb build check-web --summary all` (exit 0)

`scripts/zb build test-sdk-version --summary all` (exit 0)

fizzy-pm Bot commented Oct 28, 2026 •

edited

Loading