Repository navigation
Show notification health and send a local test alert - #41
Merged
Merged
Conversation
|
Snapshot diff report vs
All 1 changed screenshotsPreferencesScreenshotTest
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnkiQuest notifications can be hard to diagnose when Android permissions or channels block alerts, or when the inbox has stopped syncing. Add a Notification health screen in AnkiQuest settings that shows permission and channel status, the last successful inbox sync for the current account, and shortcuts to Android notification controls. A local test alert uses the existing message channel, so it checks real on-device delivery without notifying a friend.
The sync timestamp is recorded only after a successful inbox fetch and is scoped to the authenticated server account. The screen and alert are available in English and Spanish.
Validation: AnkiquestPollTest and AnkiquestNotifierTest passed; lintFullDebug and assembleFullDebug passed, producing four ABI debug APKs. The local test alert's visible banner, sound, and vibration still depend on the device's Android settings and should be checked on a physical phone.
CI follow-up: the new settings title satisfies the preference length rule, the health entry is excluded from analytics tracking, and the existing private-access test now checks token safety even when a background request also reaches its fixture server. The affected Play debug tests pass locally.
Review follow-up: AppCompat hid the action list when the status message was present. The health dialog now keeps its status visible alongside a test-alert button and a Settings button; Settings opens the permission and two channel shortcuts. A Robolectric regression failed on the old dialog and passes on this version. Final local validation: 54 targeted tests, full debug lint, and all four debug APKs.