Repository navigation
Make streak protection opt-out by default - #43
Merged
Merged
Conversation
Make freezes opt-out while preserving saved choices, stock and past streak history. Save a fixed rollout boundary, persist the first opt-out, and update English and Spanish settings guidance. Assisted-by: GPT-6 (implementation, regression tests, review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streak protection now defaults to enabled when a player has no saved choice. Players can opt out through the existing settings toggle; the first opt-out is recorded even before they upload reviews, repeated saves remain idempotent, and recorded opt-outs survive restarts.
Use one shared preference policy for settings responses, profiles, quest rewards and automatic protection. Persist the rollout time once so upgrading an opt-in server does not retroactively earn or spend freezes or change past streak/XP history. Existing saved freezes and preference timelines remain intact.
Update the dashboard's English/Spanish explanation and README to describe the new default and upgrade behavior. Android's existing toggle reads the server response; AnkiQuest-Android#38 updates the displayed explanation.
Validation:
Note
Assisted-by: GPT-6 (implementation, regression tests, review and PR description).