Repository navigation
chore(deps): drop the unused direct MCP SDK declaration - #372
Conversation
No Jedit code imports @modelcontextprotocol/sdk. It stays installed through @flyingrobots/graft (^1.29.0), resolved at 1.32.1 as #354 selected; fast-uri 3.1.8 and ip-address 10.7.4 are unchanged. Lockfile updated with npm uninstall --package-lock-only, which removes only the root declaration. ReplaceRange proof locks refreshed for the new package.json and package-lock.json bytes (toolchain-lock file hashes; build-lock toolchain hash, closure entries, and closure digest recomputed with the algorithm in tests/assert-build-output.mjs).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 6 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
Summary by CodeRabbit
WalkthroughThe package manifest no longer declares ChangesDependency and proof-lock update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Possibly related issues
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely identifies the main change: removing the unused direct MCP SDK dependency declaration. |
| Description check | |
The description directly explains the dependency removal, lockfile updates, transitive SDK retention, and proof-lock refreshes. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
One direct dependency leaves the page
Graft keeps the SDK in range
Proof-lock hashes turn anew
The changelog records what changed, too
A tidy manifest closes the review
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
@codex review please, focus on whether the lockfile change removes only the root declaration (the SDK must stay at 1.32.1 via @flyingrobots/graft) and whether the ReplaceRange proof-lock refresh matches the new package bytes. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…-sdk # Conflicts: # CHANGELOG.md
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Brings in #372 (drops the direct MCP SDK declaration). The ReplaceRange proof locks are recomputed for the combined tree: the toolchain lock now pins the post-#372 package.json and package-lock.json bytes and this branch's ci.yml bytes, and the build lock's toolchain-lock hash, ci.yml closure entry, and closure digest are recomputed with the algorithm in tests/assert-build-output.mjs (every closure entry verified against the tree). CHANGELOG keeps every entry.
Follow-up to #354 (merged as 2abdb15).
No Jedit code imports
@modelcontextprotocol/sdk; onlypackage.jsondeclared it. This removes that direct declaration. It does not remove the SDK from the application:@flyingrobots/graftdepends on it (^1.29.0), so it stays installed at 1.32.1, the version #354 selected.fast-uri(3.1.8) andip-address(10.7.4) are unchanged.npm uninstall --package-lock-only, which removes only the root declaration line.package.jsonandpackage-lock.jsonbytes, the same mechanical refresh as Refresh ReplaceRange proof locks after the dependency update #355 and Chore(deps): bump the npm_and_yarn group across 1 directory with 3 updates #354. The build lock's closure digest was recomputed with the input list and algorithm inedict/replace-range/tests/assert-build-output.mjs. CI's package chain rebuilds through the public compiler and verifies every lock.Dependabot's rescan after #354 is what confirms which alerts closed; this change does not alter any resolved version.